You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by XuPingyong <gi...@git.apache.org> on 2017/07/15 02:58:10 UTC
[GitHub] flink pull request #4347: [FLINK-7201] fix concurrency in JobLeaderIdService...
GitHub user XuPingyong opened a pull request:
https://github.com/apache/flink/pull/4347
[FLINK-7201] fix concurrency in JobLeaderIdService when shutdown the …
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/XuPingyong/flink FLINK-7201
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4347.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4347
----
commit 2c04107f2bb76944f1759ba7a71de56347d8a2bf
Author: pingyong.xpy <pi...@alibaba-inc.com>
Date: 2017-07-15T02:56:13Z
[FLINK-7201] fix concurrency in JobLeaderIdService when shutdown the ResourceManager
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4347: [FLINK-7201] fix concurrency in JobLeaderIdService...
Posted by XuPingyong <gi...@git.apache.org>.
Github user XuPingyong closed the pull request at:
https://github.com/apache/flink/pull/4347
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4347: [FLINK-7201] fix concurrency in JobLeaderIdService when s...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4347
I think it would be better to harden the `JobLeaderIdService` such that it can be shut down concurrently. This actually also applies to the `HeartbeatManager`, the `SlotManager` and the `ResourceManager` itself.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4347: [FLINK-7201] fix concurrency in JobLeaderIdService when s...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4347
With the changes of #4420, this problem should be resolved. Could you please close this PR then @XuPingyong.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4347: [FLINK-7201] fix concurrency in JobLeaderIdService when s...
Posted by StephanEwen <gi...@git.apache.org>.
Github user StephanEwen commented on the issue:
https://github.com/apache/flink/pull/4347
@XuPingyong Can you give us a bit of context for the review?
From the initial exception I would expect that there is something that also needs to be addressed in the `JobLeaderIdService` class...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4347: [FLINK-7201] fix concurrency in JobLeaderIdService when s...
Posted by XuPingyong <gi...@git.apache.org>.
Github user XuPingyong commented on the issue:
https://github.com/apache/flink/pull/4347
Thanks @tillrohrmann !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4347: [FLINK-7201] fix concurrency in JobLeaderIdService when s...
Posted by XuPingyong <gi...@git.apache.org>.
Github user XuPingyong commented on the issue:
https://github.com/apache/flink/pull/4347
@StephanEwen , rpcService of ResourceManager executes with only one single thread, so there is no conflicts when resourcemanager is in service. When resourceManager is shutdown by the other thread, the rpcService had better stop first.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---