[GitHub] [arrow-datafusion] waynexia commented on a diff in pull request #5947: fix: match boolean null for substrait

["waynexia (via GitHub)" <gi...@apache.org>]

waynexia commented on code in PR #5947:
URL: https://github.com/apache/arrow-datafusion/pull/5947#discussion_r1161870239


##########
datafusion/substrait/src/logical_plan/producer.rs:
##########
@@ -1330,9 +1335,7 @@ mod test {
     fn round_trip_literal(scalar: ScalarValue) -> Result<()> {
         println!("Checking round trip of {:?}", scalar);
 
-        let scalar = ScalarValue::Int32(Some(i32::MAX));

Review Comment:
   that's a part of being human :P



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org