You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by Andrew Stitcher <as...@apache.org> on 2011/12/06 23:55:17 UTC
Re: Review Request: Recreation of JCA Resource Adapter review

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/441/
-----------------------------------------------------------

(Updated 2011-12-06 22:55:17.757580)


Review request for qpid, Gordon Sim, Andrew Kennedy, Robbie Gemmell, rajith attapattu, and Weston Price.


Changes
-------

Candidate JCA code for putback to trunk:

Changes include:
* Now based on recent trunk (please ignore the spurious inter change diffs for code outside the jca tree).
* Lots of work on the examples.
* Changed code conventions to match qpid.
* Ships with configuration that works in Geronimo 2.2.1 and JBoss 5 and JBoss 6.
* All Bugs found in Red Hats testing to date fixed.

You can find the development tree for this work on github:
    git@github.com:astitcher/qpid-jca.git
This review is squashed into the branch jca-candidate.


Summary (updated)
-------

Review for qpid JCA resource adapter.

All comments welcome.


This addresses bug QPID-3044.
    https://issues.apache.org/jira/browse/QPID-3044


Diffs (updated)
-----

  /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQConnectionFactory.java 1208733 
  /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/AMQQueueBrowser.java 1208733 
  /trunk/qpid/java/build.xml 1208733 
  /trunk/qpid/java/build.deps 1208733 
  /trunk/qpid/java/client/src/main/java/org/apache/qpid/client/TopicPublisherAdapter.java 1208733 
  /trunk/qpid/java/jca/README-GERONIMO.txt PRE-CREATION 
  /trunk/qpid/java/jca/README-JBOSS.txt PRE-CREATION 
  /trunk/qpid/java/jca/README.txt PRE-CREATION 
  /trunk/qpid/java/jca/build.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/.gitignore PRE-CREATION 
  /trunk/qpid/java/jca/example/README.txt PRE-CREATION 
  /trunk/qpid/java/jca/example/build-geronimo-properties.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/build-jboss-properties.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/build-properties.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/build-properties.xml.temp PRE-CREATION 
  /trunk/qpid/java/jca/example/build.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/application.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/ejb-jar.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/geronimo-application.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/geronimo-ra.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/jboss-web.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/jboss.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/log4j.properties PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/qpid-jca-ds.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/conf/web.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/qpid-jca-example-properties.xml PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/client/QpidRequestResponseClient.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/client/QpidTestClient.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/client/QpidTestUtil.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidGoodByeListenerBean.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidGoodByeSubscriberBean.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidHelloListenerBean.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidHelloSubscriberBean.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidJMSResponderBean.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidTest.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidTestBean.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidTestLocal.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidTestRemote.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/ejb/QpidUtil.java PRE-CREATION 
  /trunk/qpid/java/jca/example/src/main/java/org/apache/qpid/jca/example/web/QpidTestServlet.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryObjectFactory.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/ConnectionFactoryProperties.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRABytesMessage.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactory.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionFactoryImpl.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionManager.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionMetaData.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAConnectionRequestInfo.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRACredential.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAException.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRALocalTransaction.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMCFProperties.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnection.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAManagedConnectionFactory.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMapMessage.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessage.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageConsumer.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageListener.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMessageProducer.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAMetaData.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAObjectMessage.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAProperties.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueBrowser.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueReceiver.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAQueueSender.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASession.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactory.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionFactoryImpl.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRASessionImpl.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAStreamMessage.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATextMessage.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicPublisher.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRATopicSubscriber.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidRAXAResource.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/QpidResourceAdapter.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/Util.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/AdminObjectFactory.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidBindingURL.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidConnectionFactoryProxy.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidDestinationProxy.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidQueue.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/admin/QpidTopic.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivation.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidActivationSpec.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/inflow/QpidMessageHandler.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/GeronimoTransactionManagerLocator.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBoss7TransactionManagerLocator.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/java/org/apache/qpid/ra/tm/JBossTransactionManagerLocator.java PRE-CREATION 
  /trunk/qpid/java/jca/src/main/resources/META-INF/jboss-ra.xml PRE-CREATION 
  /trunk/qpid/java/jca/src/main/resources/META-INF/ra.xml PRE-CREATION 
  /trunk/qpid/java/lib/geronimo-ejb_3.0_spec-1.0.1.jar UNKNOWN 
  /trunk/qpid/java/lib/geronimo-j2ee-connector_1.5_spec-2.0.0.jar UNKNOWN 
  /trunk/qpid/java/lib/geronimo-jta_1.1_spec-1.1.1.jar UNKNOWN 
  /trunk/qpid/java/lib/geronimo-kernel-2.2.1.jar UNKNOWN 

Diff: https://reviews.apache.org/r/441/diff


Testing
-------

This code is now substantially the same as tested by Red Hat, passes the TCK.


Thanks,

Andrew