You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/09/24 15:38:23 UTC
[GitHub] [flink] dmvk commented on a change in pull request #9759:
[FLINK-14169][history-server] Cleanup expired jobs from history server
dmvk commented on a change in pull request #9759: [FLINK-14169][history-server] Cleanup expired jobs from history server
URL: https://github.com/apache/flink/pull/9759#discussion_r327684485
##########
File path: flink-runtime-web/src/main/java/org/apache/flink/runtime/webmonitor/history/HistoryServerArchiveFetcher.java
##########
@@ -37,6 +37,7 @@
import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.JsonNode;
import org.apache.flink.shaded.jackson2.com.fasterxml.jackson.databind.ObjectMapper;
+import org.apache.commons.lang3.tuple.Pair;
Review comment:
I think you should beware of using third party (non-shaded) deps here. Can this be implemented without apache commons?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services