[GitHub] [camel-k] lburgazzoli commented on a diff in pull request #4315: feat(#1656) : jib poc basic integration use case

["lburgazzoli (via GitHub)" <gi...@apache.org>]

lburgazzoli commented on code in PR #4315:
URL: https://github.com/apache/camel-k/pull/4315#discussion_r1197500276


##########
pkg/builder/quarkus.go:
##########
@@ -208,6 +208,48 @@ func GenerateQuarkusProjectCommon(runtimeVersion string, quarkusVersion string,
 				},
 			},
 		},
+		maven.Plugin{
+			GroupID:    "com.google.cloud.tools",
+			ArtifactID: "jib-maven-plugin",
+			Version:    "3.3.1",
+			Dependencies: []maven.Dependency{
+				{
+					GroupID:    "com.google.cloud.tools",
+					ArtifactID: "jib-layer-filter-extension-maven",
+					Version:    "0.3.0",
+				},
+			},
+			Configuration: v1.PluginConfiguration{
+				Container: v1.Container{
+					Entrypoint: "INHERIT",
+					Args: v1.Args{
+						Arg: "jshell",
+					},
+				},
+				AllowInsecureRegistries: "true",
+				ExtraDirectories: v1.ExtraDirectories{
+					Paths: v1.Paths{
+						Path: v1.Path{
+							From: "../context",
+							Into: "/deployments",
+						},
+					},
+				},
+				PluginExtensions: v1.PluginExtensions{
+					PluginExtension: v1.PluginExtension{
+						Implementation: "com.google.cloud.tools.jib.maven.extension.layerfilter.JibLayerFilterExtension",
+						Configuration: v1.PluginExtensionConfiguration{
+							Implementation: "com.google.cloud.tools.jib.maven.extension.layerfilter.Configuration",
+							Filters: v1.Filters{
+								Filter: v1.Filter{
+									Glob: "/app/**",

Review Comment:
   this creates a single layer right ? 
   
   One of the nice things about the quarkus jib extensions is that it automatically configure jib to have some layers according to the app layout the quarkus builder generates



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org