You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/01/23 18:21:19 UTC
[GitHub] [arrow] jameswinegar opened a new pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
jameswinegar opened a new pull request #9303:
URL: https://github.com/apache/arrow/pull/9303
Helps with the debugging process.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-768639085
Hi @jameswinegar -- it appears that you branch got messed up due to the arrow release process (which involves force pushing to `apache/master`). Can you please rebase your changes against the current apache master branch? Sorry -- the process is being updated to avoid force pushes to master in subsequent releases
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-766158982
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=h1) Report
> Merging [#9303](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=desc) (3f3c08e) into [master](https://codecov.io/gh/apache/arrow/commit/67d0c2e38011cd883059e3a9fd0ea08088661707?el=desc) (67d0c2e) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9303/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9303 +/- ##
==========================================
- Coverage 81.84% 81.83% -0.01%
==========================================
Files 215 215
Lines 52949 52953 +4
==========================================
- Hits 43336 43335 -1
- Misses 9613 9618 +5
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow-flight/src/arrow.flight.protocol.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy1mbGlnaHQvc3JjL2Fycm93LmZsaWdodC5wcm90b2NvbC5ycw==) | `0.00% <ø> (ø)` | |
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `61.90% <0.00%> (-3.10%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Nzdi5ycw==) | `73.18% <0.00%> (-1.08%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=footer). Last update [67d0c2e...3f3c08e](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#discussion_r563191338
##########
File path: rust/datafusion/src/datasource/csv.rs
##########
@@ -66,7 +66,10 @@ impl CsvFile {
let mut filenames: Vec<String> = vec![];
common::build_file_list(path, &mut filenames, options.file_extension)?;
if filenames.is_empty() {
- return Err(DataFusionError::Plan("No files found".to_string()));
+ return Err(DataFusionError::Plan(format!(
+ "No files found at {path}",
Review comment:
Can we show the file extension it was looking for as well?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-766158982
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=h1) Report
> Merging [#9303](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=desc) (91fcd3a) into [master](https://codecov.io/gh/apache/arrow/commit/67d0c2e38011cd883059e3a9fd0ea08088661707?el=desc) (67d0c2e) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9303/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9303 +/- ##
==========================================
- Coverage 81.84% 81.83% -0.01%
==========================================
Files 215 215
Lines 52949 52953 +4
==========================================
Hits 43336 43336
- Misses 9613 9617 +4
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/arrow-flight/src/arrow.flight.protocol.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9hcnJvdy1mbGlnaHQvc3JjL2Fycm93LmZsaWdodC5wcm90b2NvbC5ycw==) | `0.00% <ø> (ø)` | |
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `61.90% <0.00%> (-3.10%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Nzdi5ycw==) | `73.18% <0.00%> (-1.08%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=footer). Last update [67d0c2e...7fa024a](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-766158982
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=h1) Report
> Merging [#9303](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=desc) (eb38e3e) into [master](https://codecov.io/gh/apache/arrow/commit/67d0c2e38011cd883059e3a9fd0ea08088661707?el=desc) (67d0c2e) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9303/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9303 +/- ##
==========================================
- Coverage 81.84% 81.83% -0.01%
==========================================
Files 215 215
Lines 52949 52951 +2
==========================================
- Hits 43336 43335 -1
- Misses 9613 9616 +3
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `63.41% <0.00%> (-1.59%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Nzdi5ycw==) | `73.72% <0.00%> (-0.55%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=footer). Last update [67d0c2e...3f3c08e](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb commented on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
alamb commented on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-769248095
Looks good to me -- Thanks @jameswinegar !
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] andygrove commented on a change in pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
andygrove commented on a change in pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#discussion_r563191456
##########
File path: rust/arrow-flight/src/arrow.flight.protocol.rs
##########
@@ -498,9 +498,8 @@ pub mod flight_service_server {
#[async_trait]
pub trait FlightService: Send + Sync + 'static {
#[doc = "Server streaming response type for the Handshake method."]
- type HandshakeStream: Stream<
- Item = Result<super::HandshakeResponse, tonic::Status>,
- > + Send
+ type HandshakeStream: Stream<Item = Result<super::HandshakeResponse, tonic::Status>>
+ + Send
Review comment:
This formatting change shouldn't be part of this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jameswinegar commented on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
jameswinegar commented on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-768643923
> Hi @jameswinegar -- it appears that you branch got messed up due to the arrow release process (which involves force pushing to `apache/master`). Can you please rebase your changes against the current apache master branch? Sorry -- the process is being updated to avoid force pushes to master in subsequent releases
Should be fixed, let me know if this works?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jameswinegar commented on a change in pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
jameswinegar commented on a change in pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#discussion_r563197517
##########
File path: rust/arrow-flight/src/arrow.flight.protocol.rs
##########
@@ -498,9 +498,8 @@ pub mod flight_service_server {
#[async_trait]
pub trait FlightService: Send + Sync + 'static {
#[doc = "Server streaming response type for the Handshake method."]
- type HandshakeStream: Stream<
- Item = Result<super::HandshakeResponse, tonic::Status>,
- > + Send
+ type HandshakeStream: Stream<Item = Result<super::HandshakeResponse, tonic::Status>>
+ + Send
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-766158982
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=h1) Report
> Merging [#9303](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=desc) (a424064) into [master](https://codecov.io/gh/apache/arrow/commit/67d0c2e38011cd883059e3a9fd0ea08088661707?el=desc) (67d0c2e) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9303/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9303 +/- ##
==========================================
- Coverage 81.84% 81.83% -0.01%
==========================================
Files 215 215
Lines 52949 52953 +4
==========================================
- Hits 43336 43335 -1
- Misses 9613 9618 +5
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `61.90% <0.00%> (-3.10%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Nzdi5ycw==) | `73.18% <0.00%> (-1.08%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=footer). Last update [67d0c2e...7fa024a](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] alamb closed pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
alamb closed pull request #9303:
URL: https://github.com/apache/arrow/pull/9303
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-766155985
https://issues.apache.org/jira/browse/ARROW-11360
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io edited a comment on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-766158982
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=h1) Report
> Merging [#9303](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=desc) (7fa024a) into [master](https://codecov.io/gh/apache/arrow/commit/67d0c2e38011cd883059e3a9fd0ea08088661707?el=desc) (67d0c2e) will **decrease** coverage by `0.01%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9303/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9303 +/- ##
==========================================
- Coverage 81.84% 81.83% -0.02%
==========================================
Files 215 215
Lines 52949 52955 +6
==========================================
- Hits 43336 43335 -1
- Misses 9613 9620 +7
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `60.46% <0.00%> (-4.54%)` | :arrow_down: |
| [rust/datafusion/src/physical\_plan/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Nzdi5ycw==) | `72.66% <0.00%> (-1.61%)` | :arrow_down: |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=footer). Last update [67d0c2e...7fa024a](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] jameswinegar commented on a change in pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
jameswinegar commented on a change in pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#discussion_r563197536
##########
File path: rust/datafusion/src/datasource/csv.rs
##########
@@ -66,7 +66,10 @@ impl CsvFile {
let mut filenames: Vec<String> = vec![];
common::build_file_list(path, &mut filenames, options.file_extension)?;
if filenames.is_empty() {
- return Err(DataFusionError::Plan("No files found".to_string()));
+ return Err(DataFusionError::Plan(format!(
+ "No files found at {path}",
Review comment:
fixed
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] codecov-io commented on pull request #9303: ARROW-11360: [Rust] [DataFusion] Improve CSV "No files found" error message
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #9303:
URL: https://github.com/apache/arrow/pull/9303#issuecomment-766158982
# [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=h1) Report
> Merging [#9303](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=desc) (bc2f754) into [master](https://codecov.io/gh/apache/arrow/commit/67d0c2e38011cd883059e3a9fd0ea08088661707?el=desc) (67d0c2e) will **decrease** coverage by `0.00%`.
> The diff coverage is `0.00%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/arrow/pull/9303/graphs/tree.svg?width=650&height=150&src=pr&token=LpTCFbqVT1)](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #9303 +/- ##
==========================================
- Coverage 81.84% 81.84% -0.01%
==========================================
Files 215 215
Lines 52949 52949
==========================================
- Hits 43336 43335 -1
- Misses 9613 9614 +1
```
| [Impacted Files](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [rust/datafusion/src/datasource/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9kYXRhc291cmNlL2Nzdi5ycw==) | `65.00% <0.00%> (ø)` | |
| [rust/datafusion/src/physical\_plan/csv.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9kYXRhZnVzaW9uL3NyYy9waHlzaWNhbF9wbGFuL2Nzdi5ycw==) | `74.26% <0.00%> (ø)` | |
| [rust/parquet/src/encodings/encoding.rs](https://codecov.io/gh/apache/arrow/pull/9303/diff?src=pr&el=tree#diff-cnVzdC9wYXJxdWV0L3NyYy9lbmNvZGluZ3MvZW5jb2RpbmcucnM=) | `95.24% <0.00%> (-0.20%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=footer). Last update [67d0c2e...3f3c08e](https://codecov.io/gh/apache/arrow/pull/9303?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org