[GitHub] [trafficserver] masaori335 commented on a change in pull request #7225: Increment ssl_error_syscall only if not EOF

[GitBox <gi...@apache.org>]

masaori335 commented on a change in pull request #7225:
URL: https://github.com/apache/trafficserver/pull/7225#discussion_r497156908



##########
File path: iocore/net/SSLNetVConnection.cc
##########
@@ -306,15 +306,14 @@ ssl_read_from_net(SSLNetVConnection *sslvc, EThread *lthread, int64_t &ret)
       Debug("ssl.error", "SSL_ERROR_WOULD_BLOCK(read/x509 lookup)");
       break;
     case SSL_ERROR_SYSCALL:
-      SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
       if (nread != 0) {
         // not EOF
+        SSL_INCREMENT_DYN_STAT(ssl_error_syscall);
         event = SSL_READ_ERROR;
         ret   = errno;
         Debug("ssl.error", "SSL_ERROR_SYSCALL, underlying IO error: %s", strerror(errno));
       } else {
         // then EOF observed, treat it as EOS

Review comment:
       Actually, it's my first idea. But I decided to do nothing to follow what we did for `SSL_ERROR_WANT_WRITE`, `SSL_ERROR_WANT_READ`, and `SSL_ERROR_ZERO_RETURN` with #5389.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org