[jira] [Commented] (CLOUDSTACK-6129) Script names are hard-coded into some init scripts

["ASF subversion and git services (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CLOUDSTACK-6129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13903418#comment-13903418 ] 

ASF subversion and git services commented on CLOUDSTACK-6129:
-------------------------------------------------------------

Commit 9dd57c22b02afcddb1d6c8ddc3e1b578961454e3 in cloudstack's branch refs/heads/master from [~jlkinsel]
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=9dd57c2 ]

CLOUDSTACK-6129: removing hard-coded script names

Replacing whatami with $0 which is how UNIX shell scripts should get the
script's name.

BUG-ID: CLOUDSTACK-6129
Bugfix-for:
Reviewed-by:
Reported-by:
Signed-off-by: John Kinsella <jl...@stratosec.co> 1392660036 -0800


> Script names are hard-coded into some init scripts
> --------------------------------------------------
>
>                 Key: CLOUDSTACK-6129
>                 URL: https://issues.apache.org/jira/browse/CLOUDSTACK-6129
>             Project: CloudStack
>          Issue Type: Bug
>      Security Level: Public(Anyone can view this level - this is the default.) 
>          Components: Install and Setup
>            Reporter: John Kinsella
>            Assignee: John Kinsella
>             Fix For: 4.4.0
>
>
> Some of the init scripts which ACS installs have the script name hard-coded into it. An example from python/distro/sles/SYSCONFDIR/init.d/cloud-ipallocator.in:
>     whatami=cloud-external-ipallocator
>     ...
>     echo $"Usage: $whatami {start|stop|restart|status|help}"
> This is bad practice, $0 should be used to get a script's name, otherwise - as shown in this example - things will fail or folks will be confused.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)