You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2020/09/02 16:43:58 UTC
[GitHub] [helix] alirezazamani commented on a change in pull request #1326: Task Framework IdealState Removal
alirezazamani commented on a change in pull request #1326:
URL: https://github.com/apache/helix/pull/1326#discussion_r482212002
##########
File path: helix-core/src/main/java/org/apache/helix/task/WorkflowDispatcher.java
##########
@@ -290,7 +297,6 @@ private void scheduleJobs(String workflow, WorkflowConfig workflowCfg,
// Time is not ready. Set a trigger and update the start time.
// Check if the job is ready to be executed.
if (System.currentTimeMillis() >= workflowCtx.getJobStartTime(job)) {
- scheduleSingleJob(job, jobConfig);
Review comment:
Can remind me why scheduleSignleJob is removed? We already schedule the job in other places?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org