You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by le...@apache.org on 2019/11/22 01:31:34 UTC

[incubator-datasketches-vector] branch master updated: Update Checkstyle config

This is an automated email from the ASF dual-hosted git repository.

leerho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-datasketches-vector.git


The following commit(s) were added to refs/heads/master by this push:
     new ff268c4  Update Checkstyle config
ff268c4 is described below

commit ff268c4cb4056b35c25df96fe8ee3ff79c25545f
Author: Lee Rhodes <le...@users.noreply.github.com>
AuthorDate: Thu Nov 21 17:31:22 2019 -0800

    Update Checkstyle config
---
 tools/SketchesCheckstyle.xml | 26 +++++++++++++-------------
 1 file changed, 13 insertions(+), 13 deletions(-)

diff --git a/tools/SketchesCheckstyle.xml b/tools/SketchesCheckstyle.xml
index f65c1cd..b7659fd 100644
--- a/tools/SketchesCheckstyle.xml
+++ b/tools/SketchesCheckstyle.xml
@@ -1,7 +1,7 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <!DOCTYPE module PUBLIC
-      "-//Puppy Crawl//DTD Check Configuration 1.3//EN"
-      "http://www.puppycrawl.com/dtds/configuration_1_3.dtd"> <!-- does not work with https -->
+    "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
+    "https://checkstyle.org/dtds/configuration_1_3.dtd">
 
 <!--
 Licensed to the Apache Software Foundation (ASF) under one
@@ -23,7 +23,7 @@ under the License.
 -->
 
 <!--
-  SketchesCheckstyle.xml for sketches-core
+  SketchesCheckstyle.xml
 
   Checkstyle is very configurable. Be sure to read the documentation at
   http://checkstyle.sourceforge.net (or in your downloaded distribution). Note: Does not work with https.
@@ -48,6 +48,14 @@ under the License.
     <property name="lineSeparator" value="lf"/>
   </module>
   
+  <!-- Size Violations -->
+  <module name="LineLength">
+    <property name="severity" value="warning"/>
+    <property name="max" value="110"/>
+    <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
+    <!-- <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> -->
+  </module>
+  
   <module name="TreeWalker">
     
     <!-- Annotations -->
@@ -165,7 +173,7 @@ under the License.
     <module name="UnusedImports"/>
     
     <!-- Filters -->
-    <!-- Enable suppression using comments: //CHECKSTYLE.OFF "RULE" and //CHECKSTYLE.ON "RULE"
+    <!-- Enable suppression using comments: //CHECKSTYLE.OFF: "RULE" and //CHECKSTYLE.ON: "RULE"
      You must specify the specific rule, as in: //CHECKSTYLE.OFF: LineLength -->
     <module name="SuppressionCommentFilter">
       <property name="offCommentFormat" value="CHECKSTYLE.OFF\: ([\w\|]+)"/>
@@ -185,7 +193,7 @@ under the License.
       <property name="allowMissingParamTags" value="false"/>
       <property name="allowMissingThrowsTags" value="true"/>
       <property name="allowMissingReturnTag" value="false"/>
-      <property name="minLineCount" value="2"/>
+      <!-- <property name="minLineCount" value="2"/> -->
       <property name="allowedAnnotations" value="Override, Test"/>
       <property name="allowThrowsTagsForSubclasses" value="true"/>
     </module>
@@ -333,14 +341,6 @@ under the License.
       <property name="ignoreComments" value="true"/>
     </module>
     
-    <!-- Size Violations -->
-    <module name="LineLength">
-      <property name="severity" value="warning"/>
-      <property name="max" value="110"/>
-      <property name="ignorePattern" value="^package.*|^import.*|a href|href|http://|https://|ftp://"/>
-      <!-- <metadata name="net.sf.eclipsecs.core.lastEnabledSeverity" value="inherit"/> -->
-    </module>
-    
     <!-- Whitespace -->
     <module name="EmptyLineSeparator">
       <property name="allowNoEmptyLineBetweenFields" value="true"/>


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org