You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "jmalkin (via GitHub)" <gi...@apache.org> on 2024/02/14 07:46:20 UTC
[I] Checkstyle config is broken (datasketches-java)
jmalkin opened a new issue, #507:
URL: https://github.com/apache/datasketches-java/issues/507
When running checkstyle, there are two issues:
* suppressions replies on undefined variable `${config_loc}`
* There is an exception: `Caused by: java.lang.IllegalArgumentException: 'other' is different type of Path`
I was able to remedy these to where I can now run it as
`java -Dconfig_loc=tools -jar /opt/homebrew/Cellar/checkstyle/10.13.0/libexec/checkstyle-10.13.0-all.jar -c tools/SketchesCheckstyle.xml src`
but even that required modifying the SketchesCheckstyle.xml to add a path to Checker's basedir in the config: https://github.com/apache/datasketches-java/blob/master/tools/SketchesCheckstyle.xml#L39
Maybe this runs in specific IDEs as-is, but we need to make sure we're not exploiting quirks of an IDE if we expect people to run this routinely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [I] Checkstyle config is broken (datasketches-java)
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on issue #507:
URL: https://github.com/apache/datasketches-java/issues/507#issuecomment-1943257106
Removing that basedir line entirely might work for that part, but doesn't solve the missing `${config_loc}` issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org