You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/10 06:45:02 UTC
[GitHub] [spark] ScrapCodes commented on a change in pull request #26826:
[SPARK-30195][SQL][CORE][ML] Change some function,
import definitions to work with stricter compiler in Scala 2.13
ScrapCodes commented on a change in pull request #26826: [SPARK-30195][SQL][CORE][ML] Change some function, import definitions to work with stricter compiler in Scala 2.13
URL: https://github.com/apache/spark/pull/26826#discussion_r355865779
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/expressions/Window.scala
##########
@@ -19,7 +19,7 @@ package org.apache.spark.sql.expressions
import org.apache.spark.annotation.Stable
import org.apache.spark.sql.Column
-import org.apache.spark.sql.catalyst.expressions._
+import org.apache.spark.sql.catalyst.expressions.{WindowSpec => _, _}
Review comment:
Ahh, I see. Will it be nicer to import `WindowSpec`, explicitly?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org