[GitHub] [trafficcontrol] shamrickus commented on a change in pull request #6054: Traffic Portal controls for Delivery Service TLS Versions

[GitBox <gi...@apache.org>]

shamrickus commented on a change in pull request #6054:
URL: https://github.com/apache/trafficcontrol/pull/6054#discussion_r686025471



##########
File path: traffic_portal/app/src/common/modules/form/deliveryService/FormDeliveryServiceController.js
##########
@@ -19,6 +19,72 @@
 
 var FormDeliveryServiceController = function(deliveryService, dsCurrent, origin, topologies, type, types, $scope, $location, $uibModal, $window, formUtils, locationUtils, tenantUtils, deliveryServiceUtils, cdnService, profileService, tenantService, propertiesModel, userModel, serviceCategoryService) {
 
+    const knownVersions = new Set(["1.0", "1.1", "1.2", "1.3"]);
+    $scope.tlsVersionUnknown = v => v && !knownVersions.has(v);
+
+    const insecureVersions = new Set(["1.0", "1.1"])
+    $scope.tlsVersionInsecure = v => v && insecureVersions.has(v);
+
+    $scope.toggleTLSRestrict = () => {
+        deliveryService.tlsVersions = $scope.restrictTLS ? [""] : null;
+    }
+
+    $scope.removeTLSVersion = function(index) {
+        deliveryService.tlsVersions.splice(index, 1);
+    }
+
+    $scope.addTLSVersion = function(index) {
+        deliveryService.tlsVersions.splice(index+1, 0, "");
+    }

Review comment:
       missing semicolon




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@trafficcontrol.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org