You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2018/09/05 00:29:03 UTC

[GitHub] codecov-io edited a comment on issue #5806: When export to CSV on a Windows OS, use a independent encoding settin…

codecov-io edited a comment on issue #5806: When export to CSV on a Windows OS, use a independent encoding settin…
URL: https://github.com/apache/incubator-superset/pull/5806#issuecomment-418560021
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5806?src=pr&el=h1) Report
   > Merging [#5806](https://codecov.io/gh/apache/incubator-superset/pull/5806?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/d43813ff09e4878e6fa964c87ce8b29b38b4597d?src=pr&el=desc) will **increase** coverage by `<.01%`.
   > The diff coverage is `90.9%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-superset/pull/5806/graphs/tree.svg?width=650&token=KsB0fHcx6l&height=150&src=pr)](https://codecov.io/gh/apache/incubator-superset/pull/5806?src=pr&el=tree)
   
   ```diff
   @@            Coverage Diff             @@
   ##           master    #5806      +/-   ##
   ==========================================
   + Coverage   63.82%   63.83%   +<.01%     
   ==========================================
     Files         364      364              
     Lines       23099    23108       +9     
     Branches     2587     2587              
   ==========================================
   + Hits        14744    14752       +8     
   - Misses       8340     8341       +1     
     Partials       15       15
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/5806?src=pr&el=tree) | Coverage Δ | |
   |---|---|---|
   | [superset/config.py](https://codecov.io/gh/apache/incubator-superset/pull/5806/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29uZmlnLnB5) | `92.64% <100%> (+0.05%)` | :arrow_up: |
   | [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/5806/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `74.38% <100%> (+0.09%)` | :arrow_up: |
   | [superset/viz.py](https://codecov.io/gh/apache/incubator-superset/pull/5806/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdml6LnB5) | `81.32% <80%> (-0.03%)` | :arrow_down: |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5806?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/5806?src=pr&el=footer). Last update [d43813f...4c2b531](https://codecov.io/gh/apache/incubator-superset/pull/5806?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org