You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "paleolimbot (via GitHub)" <gi...@apache.org> on 2025/03/23 21:09:29 UTC
[PR] feat(r): Add zstd decompression support to R package [arrow-nanoarrow]
paleolimbot opened a new pull request, #733:
URL: https://github.com/apache/arrow-nanoarrow/pull/733
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(r): Add zstd decompression support to R package [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #733:
URL: https://github.com/apache/arrow-nanoarrow/pull/733#issuecomment-2766773159
Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(r): Add zstd decompression support to R package [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot commented on PR #733:
URL: https://github.com/apache/arrow-nanoarrow/pull/733#issuecomment-2751545955
@assignUser I feel like I've abused your review capacity recently, but if you have a minute in the next few days this would benefit from a sanity check 😬
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(r): Add zstd decompression support to R package [arrow-nanoarrow]
Posted by "assignUser (via GitHub)" <gi...@apache.org>.
assignUser commented on code in PR #733:
URL: https://github.com/apache/arrow-nanoarrow/pull/733#discussion_r2019978734
##########
r/R/ipc.R:
##########
@@ -145,9 +145,20 @@ write_nanoarrow.character <- function(data, x, ...) {
write_nanoarrow(data, con)
}
-#' @rdname read_nanoarrow
+#' Example Arrow IPC Data
+#'
+#' An example stream that can be used for testing or examples.
+#'
+#' @param compression One of "none" or "zstd"
+#'
+#' @return A raw vector that can be passed to [read_nanoarrow()]
#' @export
-example_ipc_stream <- function() {
+#'
+#' @examples
+#' as.data.frame(read_nanoarrow(example_ipc_stream()))
+example_ipc_stream <- function(compression = c("none", "zstd")) {
Review Comment:
This is a nice choice, exporting it, instead of hiding it in a test helper!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(r): Add zstd decompression support to R package [arrow-nanoarrow]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #733:
URL: https://github.com/apache/arrow-nanoarrow/pull/733#issuecomment-2746472033
## [Codecov](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/733?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
Attention: Patch coverage is `75.00000%` with `1 line` in your changes missing coverage. Please review.
> Project coverage is 79.94%. Comparing base [(`18652fc`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/18652fccbace6ac41e67f78447e46718f63cd03e?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to head [(`722312c`)](https://app.codecov.io/gh/apache/arrow-nanoarrow/commit/722312c0b8f621b844651f147d9de8993ffd0402?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 21 commits behind head on main.
| [Files with missing lines](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/733?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Patch % | Lines |
|---|---|---|
| [r/src/as\_array.c](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/733?src=pr&el=tree&filepath=r%2Fsrc%2Fas_array.c&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-ci9zcmMvYXNfYXJyYXkuYw==) | 75.00% | [1 Missing :warning: ](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/733?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #733 +/- ##
==========================================
+ Coverage 79.24% 79.94% +0.69%
==========================================
Files 105 105
Lines 15065 15376 +311
Branches 1712 1732 +20
==========================================
+ Hits 11939 12292 +353
+ Misses 2044 1994 -50
- Partials 1082 1090 +8
```
</details>
[:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/arrow-nanoarrow/pull/733?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] feat(r): Add zstd decompression support to R package [arrow-nanoarrow]
Posted by "paleolimbot (via GitHub)" <gi...@apache.org>.
paleolimbot merged PR #733:
URL: https://github.com/apache/arrow-nanoarrow/pull/733
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org