You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by Marshall Shi <sh...@cn.ibm.com> on 2013/03/02 03:50:15 UTC
Re: Review Request: gadget iframe title fix
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/
-----------------------------------------------------------
(Updated March 2, 2013, 2:50 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
Description
-------
Fix problem of the patch committed in this review:
https://reviews.apache.org/r/6561/
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js 1431869
Diff: https://reviews.apache.org/r/9674/diff/
Testing
-------
Done.
Thanks,
Marshall Shi
Re: Review Request: gadget iframe title fix
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/#review17660
-----------------------------------------------------------
Ship it!
Committed revision 1454914
- Ryan Baxter
On March 8, 2013, 6:13 a.m., Marshall Shi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9674/
> -----------------------------------------------------------
>
> (Updated March 8, 2013, 6:13 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> Fix problem of the patch committed in this review:
>
> https://reviews.apache.org/r/6561/
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js 1454254
>
> Diff: https://reviews.apache.org/r/9674/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Marshall Shi
>
>
Re: Review Request: gadget iframe title fix
Posted by Marshall Shi <sh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/
-----------------------------------------------------------
(Updated March 8, 2013, 6:13 a.m.)
Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
Changes
-------
- update code to fix failed cases.
Description
-------
Fix problem of the patch committed in this review:
https://reviews.apache.org/r/6561/
Diffs (updated)
-----
http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js 1454254
Diff: https://reviews.apache.org/r/9674/diff/
Testing
-------
Done.
Thanks,
Marshall Shi
Re: Review Request: gadget iframe title fix
Posted by Dan Dumont <dd...@us.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/#review17335
-----------------------------------------------------------
Ship it!
Ship It!
- Dan Dumont
On March 2, 2013, 2:50 a.m., Marshall Shi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9674/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 2:50 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> Fix problem of the patch committed in this review:
>
> https://reviews.apache.org/r/6561/
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js 1431869
>
> Diff: https://reviews.apache.org/r/9674/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Marshall Shi
>
>
Re: Review Request: gadget iframe title fix
Posted by Ryan Baxter <rb...@gmail.com>.
> On March 7, 2013, 1:55 p.m., Ryan Baxter wrote:
> > Committed please close the review
I take that back. I had to revert the change because there are Javascript unit tests failing. Please reopen the review and fix the tests.
- Ryan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/#review17540
-----------------------------------------------------------
On March 2, 2013, 2:50 a.m., Marshall Shi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9674/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 2:50 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> Fix problem of the patch committed in this review:
>
> https://reviews.apache.org/r/6561/
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js 1431869
>
> Diff: https://reviews.apache.org/r/9674/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Marshall Shi
>
>
Re: Review Request: gadget iframe title fix
Posted by Ryan Baxter <rb...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/#review17540
-----------------------------------------------------------
Ship it!
Committed please close the review
- Ryan Baxter
On March 2, 2013, 2:50 a.m., Marshall Shi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9674/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 2:50 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> Fix problem of the patch committed in this review:
>
> https://reviews.apache.org/r/6561/
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js 1431869
>
> Diff: https://reviews.apache.org/r/9674/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Marshall Shi
>
>
Re: Review Request: gadget iframe title fix
Posted by Marshall Shi <sh...@cn.ibm.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/#review17533
-----------------------------------------------------------
Ryan, any more comments? If not, please help to commit this change.
- Marshall Shi
On March 2, 2013, 2:50 a.m., Marshall Shi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9674/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 2:50 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> Fix problem of the patch committed in this review:
>
> https://reviews.apache.org/r/6561/
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js 1431869
>
> Diff: https://reviews.apache.org/r/9674/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Marshall Shi
>
>
Re: Review Request: gadget iframe title fix
Posted by Stanton Sievers <si...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/9674/#review17313
-----------------------------------------------------------
Ship it!
Ship It!
- Stanton Sievers
On March 2, 2013, 2:50 a.m., Marshall Shi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/9674/
> -----------------------------------------------------------
>
> (Updated March 2, 2013, 2:50 a.m.)
>
>
> Review request for shindig, Ryan Baxter, Dan Dumont, Stanton Sievers, and Rich Thompson.
>
>
> Description
> -------
>
> Fix problem of the patch committed in this review:
>
> https://reviews.apache.org/r/6561/
>
>
> Diffs
> -----
>
> http://svn.apache.org/repos/asf/shindig/trunk/features/src/main/javascript/features/container.site/site.js 1431869
>
> Diff: https://reviews.apache.org/r/9674/diff/
>
>
> Testing
> -------
>
> Done.
>
>
> Thanks,
>
> Marshall Shi
>
>