[GitHub] [opennlp-sandbox] rzo1 commented on a diff in pull request #81: Update sandbox component 'opennlp-dl' to be compatible with latest opennlp-tools release

["rzo1 (via GitHub)" <gi...@apache.org>]

rzo1 commented on code in PR #81:
URL: https://github.com/apache/opennlp-sandbox/pull/81#discussion_r1097099607


##########
opennlp-dl/src/main/java/opennlp/tools/dl/NeuralDocCatModel.java:
##########
@@ -9,16 +33,10 @@
 import org.slf4j.Logger;
 import org.slf4j.LoggerFactory;
 
-import java.io.*;
-import java.util.*;
-import java.util.zip.ZipEntry;
-import java.util.zip.ZipInputStream;
-import java.util.zip.ZipOutputStream;
-
 /**
  * This class is a wrapper for DL4J's {@link MultiLayerNetwork}, and {@link GlobalVectors}
  * that provides features to serialize and deserialize necessary data to a zip file.
- *
+ * <p>
  * This cane be used by a Neural Trainer tool to serialize the network and a predictor tool to restore the same network

Review Comment:
   `can`



##########
opennlp-dl/src/main/java/opennlp/tools/dl/NeuralDocCatModel.java:
##########
@@ -129,16 +146,17 @@ public int getMaxSeqLen() {
     }
 
     /**
-     * Zips the current state of the model and writes it stream
-     * @param stream stream to write
-     * @throws IOException
+     * Zips the current state of the model and writes it stream.

Review Comment:
   `into the given stream` ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org