You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2020/02/27 07:15:53 UTC
[GitHub] [flink] hequn8128 commented on a change in pull request #11220:
[FLINK-16249][python][ml] Add interfaces for Params, ParamInfo and WithParams
hequn8128 commented on a change in pull request #11220: [FLINK-16249][python][ml] Add interfaces for Params, ParamInfo and WithParams
URL: https://github.com/apache/flink/pull/11220#discussion_r384947771
##########
File path: flink-python/setup.py
##########
@@ -224,7 +224,7 @@ def remove_if_exists(file_path):
author_email='dev@flink.apache.org',
python_requires='>=3.5',
install_requires=['py4j==0.10.8.1', 'python-dateutil==2.8.0', 'apache-beam==2.19.0',
- 'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1'],
+ 'cloudpickle==1.2.2', 'avro-python3>=1.8.1,<=1.9.1', 'jsonpickle==1.2'],
Review comment:
From the user's perspective and the size of jsonpickle(74.7 kB), maybe keep jsonpicke in install_requires is more user-friendly? i.e., users don't need to specify the ml arguments when installing pyflink.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services