You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2023/01/18 14:49:20 UTC
[GitHub] [beam] damccorm opened a new pull request, #25055: Remove trailing whitespace from blog to fix precommit
damccorm opened a new pull request, #25055:
URL: https://github.com/apache/beam/pull/25055
This fixes the breakages introduced by #24951 by removing trailing whitespace. It is an alternative to #25048 which removes the rule.
------------------------
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [ ] Mention the appropriate issue in your description (for example: `addresses #123`), if applicable. This will automatically add a link to the pull request in the issue. If you would like the issue to automatically close on merging the pull request, comment `fixes #<ISSUE NUMBER>` instead.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more tips on [how to make review process smoother](https://beam.apache.org/contribute/get-started-contributing/#make-the-reviewers-job-easier).
To check the build health, please visit [https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md](https://github.com/apache/beam/blob/master/.test-infra/BUILD_STATUS.md)
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
[](https://github.com/apache/beam/actions?query=workflow%3A%22Build+python+source+distribution+and+wheels%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Python+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Java+Tests%22+branch%3Amaster+event%3Aschedule)
[](https://github.com/apache/beam/actions?query=workflow%3A%22Go+tests%22+branch%3Amaster+event%3Aschedule)
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik merged pull request #25055: Remove trailing whitespace from blog to fix precommit
Posted by GitBox <gi...@apache.org>.
lukecwik merged PR #25055:
URL: https://github.com/apache/beam/pull/25055
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25055: Remove trailing whitespace from blog to fix precommit
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #25055:
URL: https://github.com/apache/beam/pull/25055#issuecomment-1387443110
I'm happy with this as well and I'm going to merge this to get a green signal. We can always revert and remove the whitespace check in the future if people like the alternative more.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] lukecwik commented on pull request #25055: Remove trailing whitespace from blog to fix precommit
Posted by GitBox <gi...@apache.org>.
lukecwik commented on PR #25055:
URL: https://github.com/apache/beam/pull/25055#issuecomment-1387445026
The [website](https://ci-beam.apache.org/job/beam_PreCommit_Website_Commit/10348/) and [whitespace](https://ci-beam.apache.org/job/beam_PreCommit_Whitespace_Commit/10449/) checks passed, just delayed update here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25055: Remove trailing whitespace from blog to fix precommit
Posted by GitBox <gi...@apache.org>.
kennknowles commented on PR #25055:
URL: https://github.com/apache/beam/pull/25055#issuecomment-1397698255
This alters `<br />` to `<p />` does it not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [beam] kennknowles commented on pull request #25055: Remove trailing whitespace from blog to fix precommit
Posted by "kennknowles (via GitHub)" <gi...@apache.org>.
kennknowles commented on PR #25055:
URL: https://github.com/apache/beam/pull/25055#issuecomment-1423170940
Just to answer my own question, yes: this PR is not equivalent to what it replaced, but adds a lot of whitespace to the blog post. It reads well anyhow, but wanted to be clear that this is a formatting change, not an alternative formulation of the same formatting.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org