You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Swapan Shridhar <ss...@hortonworks.com> on 2016/02/11 02:27:52 UTC
Review Request 43463: AMBARI-15002. HiveServerInteractive. Adding
skelton code for Hive Server Interactive component support.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43463/
-----------------------------------------------------------
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Gupta.
Bugs: AMBARI-15002
https://issues.apache.org/jira/browse/AMBARI-15002
Repository: ambari
Description
-------
- Added skelton code for "Hive Server Interactive" component support.
- A dummy Hive component "Hive Server2 Interactive" will show up on UI, but will not have any backing start, stop etc. code. (next in line in terms of checkin).
- Along with that, added the "hive-interactive-site.xml" for configs.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml 82bdc92
Diff: https://reviews.apache.org/r/43463/diff/
Testing
-------
- Using HDP 2.4 stack : Component shows up on UI using HDP 2.4.
- Using HDP 2.3 stack : Isolated from my changes and "HiveServer2 Interactive" component doesn't show up.
- Python tests pass.
Thanks,
Swapan Shridhar
Re: Review Request 43463: AMBARI-15002. HiveServerInteractive. Adding
skelton code for Hive Server Interactive component support.
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43463/#review118845
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml (lines 67 - 69)
<https://reviews.apache.org/r/43463/#comment180151>
If we are planning to use hive-interactive-site.xml for hiveserver2 interactive component then it needs to be added over here in configuration-dependencies tag and also in hive service's configuration-dependencies tag
- Jaimin Jetly
On Feb. 11, 2016, 1:29 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43463/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 1:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Gupta.
>
>
> Bugs: AMBARI-15002
> https://issues.apache.org/jira/browse/AMBARI-15002
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added skelton code for "Hive Server Interactive" component support.
> - A dummy Hive component "Hive Server2 Interactive" will show up on UI, but will not have any backing start, stop etc. code. (next in line in terms of checkin).
> - Along with that, added the "hive-interactive-site.xml" for configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml 82bdc92
>
> Diff: https://reviews.apache.org/r/43463/diff/
>
>
> Testing
> -------
>
> - Using HDP 2.4 stack : Component shows up on UI using HDP 2.4. Screenshot : ""HiveServer2 Interactive" component"
> - Using HDP 2.3 stack : Isolated from my changes and "HiveServer2 Interactive" component doesn't show up.
> - Python tests pass.
>
>
> File Attachments
> ----------------
>
> "HiveServer2 Interactive" component
> https://reviews.apache.org/media/uploaded/files/2016/02/11/d260200a-505a-400a-a012-53d61101d024__Screen_Shot_2016-02-10_at_5.20.25_PM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 43463: AMBARI-15002. HiveServerInteractive. Adding
skelton code for Hive Server Interactive component support.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
> On Feb. 11, 2016, 9:54 a.m., Jaimin Jetly wrote:
> > ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml, lines 1280-1283
> > <https://reviews.apache.org/r/43463/diff/1/?file=1240090#file1240090line1280>
> >
> > This line of code has been removed in recent commit from hive-site.xml
Removed.
- Swapan
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43463/#review118843
-----------------------------------------------------------
On Feb. 11, 2016, 1:29 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43463/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 1:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Gupta.
>
>
> Bugs: AMBARI-15002
> https://issues.apache.org/jira/browse/AMBARI-15002
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added skelton code for "Hive Server Interactive" component support.
> - A dummy Hive component "Hive Server2 Interactive" will show up on UI, but will not have any backing start, stop etc. code. (next in line in terms of checkin).
> - Along with that, added the "hive-interactive-site.xml" for configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml 82bdc92
>
> Diff: https://reviews.apache.org/r/43463/diff/
>
>
> Testing
> -------
>
> - Using HDP 2.4 stack : Component shows up on UI using HDP 2.4. Screenshot : ""HiveServer2 Interactive" component"
> - Using HDP 2.3 stack : Isolated from my changes and "HiveServer2 Interactive" component doesn't show up.
> - Python tests pass.
>
>
> File Attachments
> ----------------
>
> "HiveServer2 Interactive" component
> https://reviews.apache.org/media/uploaded/files/2016/02/11/d260200a-505a-400a-a012-53d61101d024__Screen_Shot_2016-02-10_at_5.20.25_PM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 43463: AMBARI-15002. HiveServerInteractive. Adding
skelton code for Hive Server Interactive component support.
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43463/#review118843
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml (lines 1280 - 1283)
<https://reviews.apache.org/r/43463/#comment180149>
This line of code has been removed in recent commit from hive-site.xml
- Jaimin Jetly
On Feb. 11, 2016, 1:29 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43463/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 1:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Gupta.
>
>
> Bugs: AMBARI-15002
> https://issues.apache.org/jira/browse/AMBARI-15002
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added skelton code for "Hive Server Interactive" component support.
> - A dummy Hive component "Hive Server2 Interactive" will show up on UI, but will not have any backing start, stop etc. code. (next in line in terms of checkin).
> - Along with that, added the "hive-interactive-site.xml" for configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml 82bdc92
>
> Diff: https://reviews.apache.org/r/43463/diff/
>
>
> Testing
> -------
>
> - Using HDP 2.4 stack : Component shows up on UI using HDP 2.4. Screenshot : ""HiveServer2 Interactive" component"
> - Using HDP 2.3 stack : Isolated from my changes and "HiveServer2 Interactive" component doesn't show up.
> - Python tests pass.
>
>
> File Attachments
> ----------------
>
> "HiveServer2 Interactive" component
> https://reviews.apache.org/media/uploaded/files/2016/02/11/d260200a-505a-400a-a012-53d61101d024__Screen_Shot_2016-02-10_at_5.20.25_PM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 43463: AMBARI-15002. HiveServerInteractive. Adding
skelton code for Hive Server Interactive component support.
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43463/#review119026
-----------------------------------------------------------
Ship it!
Ship It!
- Jaimin Jetly
On Feb. 11, 2016, 9:07 p.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43463/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 9:07 p.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Gupta.
>
>
> Bugs: AMBARI-15002
> https://issues.apache.org/jira/browse/AMBARI-15002
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added skelton code for "Hive Server Interactive" component support.
> - A dummy Hive component "Hive Server2 Interactive" will show up on UI, but will not have any backing start, stop etc. code. (next in line in terms of checkin).
> - Along with that, added the "hive-interactive-site.xml" for configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml dfa20a5
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml 82bdc92
>
> Diff: https://reviews.apache.org/r/43463/diff/
>
>
> Testing
> -------
>
> - Using HDP 2.4 stack : Component shows up on UI using HDP 2.4. Screenshot : ""HiveServer2 Interactive" component"
> - Using HDP 2.3 stack : Isolated from my changes and "HiveServer2 Interactive" component doesn't show up.
> - Python tests pass.
>
>
> File Attachments
> ----------------
>
> "HiveServer2 Interactive" component
> https://reviews.apache.org/media/uploaded/files/2016/02/11/d260200a-505a-400a-a012-53d61101d024__Screen_Shot_2016-02-10_at_5.20.25_PM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 43463: AMBARI-15002. HiveServerInteractive. Adding
skelton code for Hive Server Interactive component support.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43463/
-----------------------------------------------------------
(Updated Feb. 11, 2016, 9:07 p.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Gupta.
Changes
-------
- Incorporated Jaimin's review suggestions.
- Updated diffs.
Bugs: AMBARI-15002
https://issues.apache.org/jira/browse/AMBARI-15002
Repository: ambari
Description
-------
- Added skelton code for "Hive Server Interactive" component support.
- A dummy Hive component "Hive Server2 Interactive" will show up on UI, but will not have any backing start, stop etc. code. (next in line in terms of checkin).
- Along with that, added the "hive-interactive-site.xml" for configs.
Diffs (updated)
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/metainfo.xml dfa20a5
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml 82bdc92
Diff: https://reviews.apache.org/r/43463/diff/
Testing
-------
- Using HDP 2.4 stack : Component shows up on UI using HDP 2.4. Screenshot : ""HiveServer2 Interactive" component"
- Using HDP 2.3 stack : Isolated from my changes and "HiveServer2 Interactive" component doesn't show up.
- Python tests pass.
File Attachments
----------------
"HiveServer2 Interactive" component
https://reviews.apache.org/media/uploaded/files/2016/02/11/d260200a-505a-400a-a012-53d61101d024__Screen_Shot_2016-02-10_at_5.20.25_PM.png
Thanks,
Swapan Shridhar
Re: Review Request 43463: AMBARI-15002. HiveServerInteractive. Adding
skelton code for Hive Server Interactive component support.
Posted by Jaimin Jetly <ja...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43463/#review118844
-----------------------------------------------------------
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml (lines 1232 - 1235)
<https://reviews.apache.org/r/43463/#comment180150>
This line of code has been removed in recent commit from hive-site.xml
- Jaimin Jetly
On Feb. 11, 2016, 1:29 a.m., Swapan Shridhar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43463/
> -----------------------------------------------------------
>
> (Updated Feb. 11, 2016, 1:29 a.m.)
>
>
> Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Gupta.
>
>
> Bugs: AMBARI-15002
> https://issues.apache.org/jira/browse/AMBARI-15002
>
>
> Repository: ambari
>
>
> Description
> -------
>
> - Added skelton code for "Hive Server Interactive" component support.
> - A dummy Hive component "Hive Server2 Interactive" will show up on UI, but will not have any backing start, stop etc. code. (next in line in terms of checkin).
> - Along with that, added the "hive-interactive-site.xml" for configs.
>
>
> Diffs
> -----
>
> ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml PRE-CREATION
> ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml 82bdc92
>
> Diff: https://reviews.apache.org/r/43463/diff/
>
>
> Testing
> -------
>
> - Using HDP 2.4 stack : Component shows up on UI using HDP 2.4. Screenshot : ""HiveServer2 Interactive" component"
> - Using HDP 2.3 stack : Isolated from my changes and "HiveServer2 Interactive" component doesn't show up.
> - Python tests pass.
>
>
> File Attachments
> ----------------
>
> "HiveServer2 Interactive" component
> https://reviews.apache.org/media/uploaded/files/2016/02/11/d260200a-505a-400a-a012-53d61101d024__Screen_Shot_2016-02-10_at_5.20.25_PM.png
>
>
> Thanks,
>
> Swapan Shridhar
>
>
Re: Review Request 43463: AMBARI-15002. HiveServerInteractive. Adding
skelton code for Hive Server Interactive component support.
Posted by Swapan Shridhar <ss...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43463/
-----------------------------------------------------------
(Updated Feb. 11, 2016, 1:29 a.m.)
Review request for Ambari, Alejandro Fernandez, Jaimin Jetly, and Sumit Gupta.
Changes
-------
Added screenshot.
Bugs: AMBARI-15002
https://issues.apache.org/jira/browse/AMBARI-15002
Repository: ambari
Description
-------
- Added skelton code for "Hive Server Interactive" component support.
- A dummy Hive component "Hive Server2 Interactive" will show up on UI, but will not have any backing start, stop etc. code. (next in line in terms of checkin).
- Along with that, added the "hive-interactive-site.xml" for configs.
Diffs
-----
ambari-server/src/main/resources/common-services/HIVE/0.12.0.2.0/package/scripts/hive_server_interactive.py PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/configuration/hive-interactive-site.xml PRE-CREATION
ambari-server/src/main/resources/stacks/HDP/2.4/services/HIVE/metainfo.xml 82bdc92
Diff: https://reviews.apache.org/r/43463/diff/
Testing (updated)
-------
- Using HDP 2.4 stack : Component shows up on UI using HDP 2.4. Screenshot : ""HiveServer2 Interactive" component"
- Using HDP 2.3 stack : Isolated from my changes and "HiveServer2 Interactive" component doesn't show up.
- Python tests pass.
File Attachments (updated)
----------------
"HiveServer2 Interactive" component
https://reviews.apache.org/media/uploaded/files/2016/02/11/d260200a-505a-400a-a012-53d61101d024__Screen_Shot_2016-02-10_at_5.20.25_PM.png
Thanks,
Swapan Shridhar