You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "rfellows (via GitHub)" <gi...@apache.org> on 2024/11/22 18:12:51 UTC
[PR] [NIFI-14042] - Display the branch information for version controlled Process Groups [nifi]
rfellows opened a new pull request, #9550:
URL: https://github.com/apache/nifi/pull/9550
[NIFI-14042](https://issues.apache.org/jira/browse/NIFI-14042)
* Updated the version control tooltip to be more detailed
* If the backing registry client supports branching, display the branch as part of the updated tooltip
<img width="393" alt="Screenshot 2024-11-22 at 1 11 03 PM" src="https://github.com/user-attachments/assets/ecad1179-18b1-4f61-b9e9-16dfc39faf73">
* Fixed bugs in other registry-related dialogs where they would attempt to access registry client data that wasn't readable due to permissions (no "view" for "access to the controller"). Now, registry clients that aren't readable are not included.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-14042] - Display the branch information for version controlled Process Groups [nifi]
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan merged PR #9550:
URL: https://github.com/apache/nifi/pull/9550
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-14042] - Display the branch information for version controlled Process Groups [nifi]
Posted by "scottyaslan (via GitHub)" <gi...@apache.org>.
scottyaslan commented on code in PR #9550:
URL: https://github.com/apache/nifi/pull/9550#discussion_r1937468802
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/common/tooltips/version-control-tip/version-control-tip.component.html:
##########
@@ -16,10 +16,33 @@
-->
<div class="tooltip" [style.left.px]="left" [style.top.px]="top">
- <div>
- {{ getTrackingMessage() }}
- </div>
- <div>
+ @if (data?.versionControlInformation; as vci) {
+ <div class="flex flex-col gap-y-2 mb-3">
+ <div>
+ <div>Flow Name</div>
+ <div class="tertiary-color font-medium">{{ vci.flowName }}</div>
Review Comment:
I think we need to truncate and add a title for each of these since users can name a flow, registry, branch, or bucket anything they want.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [NIFI-14042] - Display the branch information for version controlled Process Groups [nifi]
Posted by "rfellows (via GitHub)" <gi...@apache.org>.
rfellows commented on code in PR #9550:
URL: https://github.com/apache/nifi/pull/9550#discussion_r1937474841
##########
nifi-frontend/src/main/frontend/apps/nifi/src/app/pages/flow-designer/ui/common/tooltips/version-control-tip/version-control-tip.component.html:
##########
@@ -16,10 +16,33 @@
-->
<div class="tooltip" [style.left.px]="left" [style.top.px]="top">
- <div>
- {{ getTrackingMessage() }}
- </div>
- <div>
+ @if (data?.versionControlInformation; as vci) {
+ <div class="flex flex-col gap-y-2 mb-3">
+ <div>
+ <div>Flow Name</div>
+ <div class="tertiary-color font-medium">{{ vci.flowName }}</div>
Review Comment:
good call, i'll do that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org