[GitHub] [trafficserver] maskit commented on pull request #9736: Improve performance of finding SNI Actions

["maskit (via GitHub)" <gi...@apache.org>]

maskit commented on PR #9736:
URL: https://github.com/apache/trafficserver/pull/9736#issuecomment-1579495873

   I'm not sure if we all are on the same page. The two keys I suggested on #9767 are, one for the standard way, and one for current pcre pattern matching. The both can use \* but in different ways.
   
   - A. Standard way
     - 1. No wildcard - Masaori's exact match code works for this case
     - 2. Wildcard ("*" is only allowed at the beginning, and has more restrictions) -  PCRE would not be needed
   - B. Current way
     - 1. Pattern without "*" - Masaori's exact match code does not always work, because there may be other PCRE stuff
     - 2. Pattern with "*" - Obviously PCRE
   
   If we currently allows use of PCRE, checking \* is not enough and it can cause problems if somebody use other pattern matching stuff (i.e. `.+`, `[0-9]`, etc).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@trafficserver.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org