You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by ArcherShao <gi...@git.apache.org> on 2014/05/12 16:14:14 UTC
[GitHub] spark pull request: Merge addWithoutResize and rehashIfNeeded into...
GitHub user ArcherShao opened a pull request:
https://github.com/apache/spark/pull/738
Merge addWithoutResize and rehashIfNeeded into one function.
It will be more safety to add an element, users do not need to the function rehashIfNeeded() after addWithoutResize().
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ArcherShao/sparksc branch_graphx
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/738.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #738
----
commit a8ee11664da05691ce72c79115a409e27a250a8e
Author: ArcherShao <hu...@gmail.com>
Date: 2014-05-12T14:05:03Z
Merge addWithoutResize and rehashIfNeeded into one function.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Merge addWithoutResize and rehashIfNeeded into...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/738
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request: Merge addWithoutResize and rehashIfNeeded into...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/738#issuecomment-42910236
Thanks for submitting this - but considering this is a low level building block collection and not meant to be used as a general collection library, and the method's name itself is very obvious that it doesn't do resizing, I am not sure if it is worth changing them at this point.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] spark pull request: Merge addWithoutResize and rehashIfNeeded into...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the pull request:
https://github.com/apache/spark/pull/738#issuecomment-42837187
Can one of the admins verify this patch?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---