[GitHub] [hadoop] steveloughran commented on pull request #2069: HADOOP-16830. IOStatistics API.

[GitBox <gi...@apache.org>]

steveloughran commented on pull request #2069:
URL: https://github.com/apache/hadoop/pull/2069#issuecomment-670090916


   Test `TestLocalFileSystem` failure happens as the new "BufferedIOStatisticsOutputStream" class rejects calls to Syncable APIs if the wrapped class doesn't support it. This is correct behaviour. The test is failing because Local FS doesn't support it until #2102 is in (which actually depends on this buffer class to work :).
   
   ```
   java.lang.UnsupportedOperationException: hflush not supported by org.apache.hadoop.fs.RawLocalFileSystem$LocalFSFileOutputStream@1b224a47
   	at org.apache.hadoop.fs.statistics.impl.BufferedIOStatisticsOutputStream.hflush(BufferedIOStatisticsOutputStream.java:92)
   	at org.apache.hadoop.fs.FSDataOutputStream.hflush(FSDataOutputStream.java:138)
   	at org.apache.hadoop.fs.TestLocalFileSystem.testSyncable(TestLocalFileSystem.java:176)
   
   ```
   
   I could disable the test arguing purity, but what if someone expects local FS to be syncable? Adding an option to downgrade to flush, which will be enabled for local FS until #2102 is in, at which point it can be stripped as Syncable will work


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org