You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Wellington Chevreuil (JIRA)" <ji...@apache.org> on 2019/08/07 13:26:00 UTC

[jira] [Comment Edited] (HBASE-22417) DeleteTableProcedure.deleteFromMeta method should remove table from Master's table descriptors cache

    [ https://issues.apache.org/jira/browse/HBASE-22417?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16880416#comment-16880416 ] 

Wellington Chevreuil edited comment on HBASE-22417 at 8/7/19 1:25 PM:
----------------------------------------------------------------------

This latest test failure, I do believe is unrelated to this last patch changes. When executed it against my local branch before rebasing with latest master state, it passed. After rebasing, am getting errors on a different test:
{noformat}

[ERROR] testShutdownFixupWhenDaughterHasSplit(org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster)  Time elapsed: 15.904 s  <<< FAILURE!
java.lang.AssertionError: Waiting for reference to be compacted
	at org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testShutdownFixupWhenDaughterHasSplit(TestSplitTransactionOnCluster.java:398)

{noformat}

If I revert commit *ac4e5288*, test passes back. Seems a flaky test? Noticed that this test is also failing on master build for [HBASE-22582 |https://github.com/apache/hbase/pull/341#issuecomment-508374837].



was (Author: wchevreuil):
This latest test failure, I do believe is unrelated to this last patch changes. When executed it against my local branch before rebasing with latest master state, it passed. After rebasing, am getting errors on a different test:
{noformat}
[ERROR] testShutdownFixupWhenDaughterHasSplit(org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster)  Time elapsed: 15.904 s  <<< FAILURE!
java.lang.AssertionError: Waiting for reference to be compacted
	at org.apache.hadoop.hbase.regionserver.TestSplitTransactionOnCluster.testShutdownFixupWhenDaughterHasSplit(TestSplitTransactionOnCluster.java:398)
{noformat}

If I revert commit *ac4e5288*, test passes back. Seems a flaky test? Noticed that this test is also failing on master build for [HBASE-22582 |https://github.com/apache/hbase/pull/341#issuecomment-508374837].


> DeleteTableProcedure.deleteFromMeta method should remove table from Master's table descriptors cache
> ----------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-22417
>                 URL: https://issues.apache.org/jira/browse/HBASE-22417
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Wellington Chevreuil
>            Assignee: Wellington Chevreuil
>            Priority: Major
>         Attachments: HBASE-22417.master.001.patch, HBASE-22417.master.002.patch, HBASE-22417.master.003.patch, HBASE-22417.master.004.patch, HBASE-22417.master.005.patch
>
>
> DeleteTableProcedure defines a static deleteFromMeta method that's currently used both by DeleteTableProcedure itself and TruncateTableProcedure. Sometimes, depending on the table size (and under slower, under performing FileSystems), truncation can take longer to complete *TRUNCATE_TABLE_CLEAR_FS_LAYOUT* stage, but the given table has already been deleted from meta on previous *TRUNCATE_TABLE_REMOVE_FROM_META* stage. In this case, features relying on Master's table descriptor's cache might wrongly try to reference this truncating table. Master Web UI, for example, would try to check this table state and end up showing a 500 error. 



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)