You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@phoenix.apache.org by "Hadoop QA (Jira)" <ji...@apache.org> on 2019/09/12 12:09:00 UTC

[jira] [Commented] (PHOENIX-5473) Index write failures during index rebuilds should not change index table state

    [ https://issues.apache.org/jira/browse/PHOENIX-5473?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16928485#comment-16928485 ] 

Hadoop QA commented on PHOENIX-5473:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12980176/PHOENIX-5473.master.01.patch
  against master branch at commit 1347302ce1589fd78aa888956e5e69647ce32a73.
  ATTACHMENT ID: 12980176

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 3 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +                            "CREATE %s INDEX %s ON %s  (LPAD(UPPER(NAME, 'en_US'),8,'x')||'_xyz') ASYNC ",
+            ConnectionQueryServices queryServices = conn.unwrap(PhoenixConnection.class).getQueryServices();

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.MutableIndexRebuilderIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.index.PartialIndexRebuilderIT
./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.IndexRebuildTaskIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2954//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2954//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/2954//console

This message is automatically generated.

> Index write failures during index rebuilds should not change index table state
> ------------------------------------------------------------------------------
>
>                 Key: PHOENIX-5473
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-5473
>             Project: Phoenix
>          Issue Type: Bug
>            Reporter: Kadir OZDEMIR
>            Assignee: Kadir OZDEMIR
>            Priority: Major
>             Fix For: 4.15.0, 5.1.0, 4.14.3
>
>         Attachments: PHOENIX-5473.master.01.patch
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> With PHOENIX-5018, index full rebuilds are done within UngroupedAggregateRegionObserver coprocessors like index partial rebuilds. Index partial rebuilds have been only used for mutable tables. This means that UngroupedAggregateRegionObserver had been only used for rebuilding mutable tables. With PHOENIX-5018, UngroupedAggregateRegionObserver is now used for both partial and full rebuilds and both immutable and mutable index tables. When an index replay write initiated by UngroupedAggregateRegionObserver fails, the failure is handled by PhoenixIndexFailurePolicy which disables the index table if the index write still fails after it is tried the configured number of times. PhoenixIndexFailurePolicy is also used by the Phoenix client code. However, PhoenixIndexFailurePolicy had been only applied to mutable tables and index write failures never disabled an immutable index table. This behavior has changed with PHOENIX-5018 since UngroupedAggregateRegionObserver is also used to rebuild immutable index tables. Index rebuild failures should not disable immutable tables (and mutable tables).



--
This message was sent by Atlassian Jira
(v8.3.2#803003)