[GitHub] [rocketmq] zhangjidi2016 commented on a change in pull request #2930: [ISSUE #2556] Lite pull consumer support msg trace

[GitBox <gi...@apache.org>]

zhangjidi2016 commented on a change in pull request #2930:
URL: https://github.com/apache/rocketmq/pull/2930#discussion_r638771039



##########
File path: client/src/main/java/org/apache/rocketmq/client/consumer/DefaultLitePullConsumer.java
##########
@@ -188,6 +200,57 @@ public DefaultLitePullConsumer(final String consumerGroup, RPCHook rpcHook) {
         this(null, consumerGroup, rpcHook);
     }
 
+    /**
+     * Constructor specifying consumer group and enabled msg trace flag.
+     *
+     * @param consumerGroup  Consumer group.
+     * @param enableMsgTrace Switch flag instance for message trace.
+     */
+    public DefaultLitePullConsumer(final String consumerGroup, boolean enableMsgTrace) {
+        this(null, consumerGroup, null, enableMsgTrace, null);
+    }
+
+    /**
+     * Constructor specifying consumer group, enabled msg trace flag and customized trace topic name.
+     *
+     * @param consumerGroup        Consumer group.
+     * @param enableMsgTrace       Switch flag instance for message trace.
+     * @param customizedTraceTopic The name value of message trace topic.If you don't config,you can use the default
+     *                             trace topic name.
+     */
+    public DefaultLitePullConsumer(final String consumerGroup, boolean enableMsgTrace,

Review comment:
       This is a good suggestion, but this submission still wants to be consistent with DefaultMQPushConsumer and DefaultMQProducer. If necessary, a PR can be proposed later to rectify the problem of too many constructors




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org