You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/10/03 14:05:36 UTC

[GitHub] [spark] MaxGekk commented on issue #25998: [SPARK-29328][SQL] Fix calculation of mean seconds per month

MaxGekk commented on issue #25998: [SPARK-29328][SQL] Fix calculation of mean seconds per month
URL: https://github.com/apache/spark/pull/25998#issuecomment-537960715
 
 
   > I believe we want to stick with that definition, then.
   
   Sure, we can define this function as it operates on 31 days per month.
   
   Looking at the `date_part('epoch', ...)` in the PR https://github.com/apache/spark/pull/25981 , we can say the function uses 365.25 days per year by its definition, and we should not care about consistency with other Spark functions. Am I right?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org