You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Andrew Onischuk <ao...@hortonworks.com> on 2015/02/23 14:13:20 UTC

Review Request 31303: Storm JAVA_HOME not updating after config change in Ambari

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31303/
-----------------------------------------------------------

Review request for Ambari and Dmytro Sen.


Bugs: AMBARI-9745
    https://issues.apache.org/jira/browse/AMBARI-9745


Repository: ambari


Description
-------

Users are not able to change JAVA_HOME value using storm-env template. In
Ambari-1.7 and the current trunk (Ambari-2.0) we still uses java64_home in
python scripts <https://github.com/hortonworks/ambari/blob/2.0-preview/ambari-
server/src/main/resources/common-
services/STORM/0.9.1.2.1/package/scripts/service.py>


Diffs
-----

  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 781c7ef 
  ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_check.py 6f953d1 
  ambari-server/src/test/python/stacks/2.1/STORM/test_service_check.py 5686196 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 1113409 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py e607499 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py d4d549e 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py 9e5f47c 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py dd774a8 
  ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 8a04369 

Diff: https://reviews.apache.org/r/31303/diff/


Testing
-------

mvn clean test


Thanks,

Andrew Onischuk


Re: Review Request 31303: Storm JAVA_HOME not updating after config change in Ambari

Posted by Dmytro Sen <ds...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31303/#review73556
-----------------------------------------------------------

Ship it!


Ship It!

- Dmytro Sen


On Фев. 23, 2015, 1:13 п.п., Andrew Onischuk wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/31303/
> -----------------------------------------------------------
> 
> (Updated Фев. 23, 2015, 1:13 п.п.)
> 
> 
> Review request for Ambari and Dmytro Sen.
> 
> 
> Bugs: AMBARI-9745
>     https://issues.apache.org/jira/browse/AMBARI-9745
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Users are not able to change JAVA_HOME value using storm-env template. In
> Ambari-1.7 and the current trunk (Ambari-2.0) we still uses java64_home in
> python scripts <https://github.com/hortonworks/ambari/blob/2.0-preview/ambari-
> server/src/main/resources/common-
> services/STORM/0.9.1.2.1/package/scripts/service.py>
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service.py 781c7ef 
>   ambari-server/src/main/resources/common-services/STORM/0.9.1.2.1/package/scripts/service_check.py 6f953d1 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_service_check.py 5686196 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_drpc_server.py 1113409 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_nimbus.py e607499 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_rest_api_service.py d4d549e 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor.py 9e5f47c 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_supervisor_prod.py dd774a8 
>   ambari-server/src/test/python/stacks/2.1/STORM/test_storm_ui_server.py 8a04369 
> 
> Diff: https://reviews.apache.org/r/31303/diff/
> 
> 
> Testing
> -------
> 
> mvn clean test
> 
> 
> Thanks,
> 
> Andrew Onischuk
> 
>