[GitHub] [arrow] zhztheplayer commented on a change in pull request #10883: ARROW-7272: [C++][Java] JNI bridge between RecordBatch and VectorSchemaRoot

[GitBox <gi...@apache.org>]

zhztheplayer commented on a change in pull request #10883:
URL: https://github.com/apache/arrow/pull/10883#discussion_r751102129



##########
File path: cpp/src/jni/dataset/jni_util.cc
##########
@@ -17,10 +17,15 @@
 
 #include "jni/dataset/jni_util.h"
 
-#include "arrow/util/logging.h"
-
+#include <memory>
 #include <mutex>
 
+#include "arrow/array/builder_primitive.h"
+#include "arrow/c/bridge.h"
+#include "arrow/c/helpers.h"
+#include "arrow/util/logging.h"
+#include "arrow/util/small_vector.h"

Review comment:
       removed

##########
File path: cpp/src/jni/dataset/jni_util.cc
##########
@@ -17,10 +17,15 @@
 
 #include "jni/dataset/jni_util.h"
 
-#include "arrow/util/logging.h"
-
+#include <memory>
 #include <mutex>
 
+#include "arrow/array/builder_primitive.h"

Review comment:
       Removed, thanks.

##########
File path: cpp/src/jni/dataset/jni_util.cc
##########
@@ -237,6 +251,20 @@ arrow::Result<std::shared_ptr<arrow::Schema>> FromSchemaByteArray(
   return schema;
 }
 
+arrow::Status ExportRecordBatch(JNIEnv* env, const std::shared_ptr<RecordBatch>& batch,
+                                jlong struct_array) {
+  RETURN_NOT_OK(arrow::ExportRecordBatch(
+      *batch, reinterpret_cast<struct ArrowArray*>(struct_array)));
+  return Status::OK();

Review comment:
       Done.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org