You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@madlib.apache.org by mktal <gi...@git.apache.org> on 2016/06/13 21:30:59 UTC
[GitHub] incubator-madlib pull request #45: Path: refactor with dynamic link to boost...
GitHub user mktal opened a pull request:
https://github.com/apache/incubator-madlib/pull/45
Path: refactor with dynamic link to boost regex
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mktal/incubator-madlib feature/path_refactor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-madlib/pull/45.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #45
----
commit b917baf20a04f9a3795785ec1a133b54f95ba827
Author: Xiaocheng Tang <xi...@gmail.com>
Date: 2016-03-30T17:30:07Z
Path: refactor with dynamic link to boost regex
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #45: Path: refactor with dynamic link to boost regex
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on the issue:
https://github.com/apache/incubator-madlib/pull/45
I cannot compile the code for greenplum 4.3 on OS X. It does work for Postgres 9.4 on the same system. Here is the error:
[ 65%] Linking CXX shared module lib/libmadlib.so
ld: warning: ignoring file /Users/okislal/work/madlib/xtang/buildgp/src/lib/boost/libboost_regex.dylib, file was built for x86_64 which is not the architecture being linked (i386): /Users/okislal/work/madlib/xtang/buildgp/src/lib/boost/libboost_regex.dylib
Undefined symbols for architecture i386:
"boost::basic_regex<char, boost::regex_traits<char, boost::cpp_regex_traits<char> > >::do_assign(char const*, char const*, unsigned int)", referenced from:
madlib::modules::utilities::path_pattern_match::run(madlib::dbconnector::postgres::AnyType&) in path.cpp.o
.
.
.
__gnu_cxx::__normal_iterator<char const*, std::string> boost::re_detail_106000::re_is_set_member<__gnu_cxx::__normal_iterator<char const*, std::string>, char, boost::regex_traits<char, boost::cpp_regex_traits<char> >, unsigned int>(__gnu_cxx::__normal_iterator<char const*, std::string>, __gnu_cxx::__normal_iterator<char const*, std::string>, boost::re_detail_106000::re_set_long<unsigned int> const*, boost::re_detail_106000::regex_data<char, boost::regex_traits<char, boost::cpp_regex_traits<char> > > const&, bool) in path.cpp.o
ld: symbol(s) not found for architecture i386
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [src/ports/greenplum/4.3ORCA/lib/libmadlib.so] Error 1
make[1]: *** [src/ports/greenplum/4.3ORCA/CMakeFiles/madlib_greenplum_4_3ORCA.dir/all] Error 2
make: *** [all] Error 2
It has a bunch of similar boost related errors in the middle.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib pull request #45: Path: refactor with dynamic link to boost...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-madlib/pull/45
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #45: Path: refactor with dynamic link to boost regex
Posted by mktal <gi...@git.apache.org>.
Github user mktal commented on the issue:
https://github.com/apache/incubator-madlib/pull/45
@orhankislal I just added the commit that removes the dependency on dynamic linking boost regex. Please review and comment
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-madlib issue #45: Path: refactor with dynamic link to boost regex
Posted by orhankislal <gi...@git.apache.org>.
Github user orhankislal commented on the issue:
https://github.com/apache/incubator-madlib/pull/45
@mktal Great! I tested the code on both postgresql and greenplum and they both work as intended.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---