[GitHub] [cordova-android] breautek commented on a change in pull request #928: Update check_reqs.js - allow JDK > 1.8

[GitBox <gi...@apache.org>]

breautek commented on a change in pull request #928:
URL: https://github.com/apache/cordova-android/pull/928#discussion_r441194382



##########
File path: bin/templates/cordova/lib/check_reqs.js
##########
@@ -393,11 +393,13 @@ module.exports.run = function () {
         console.log('ANDROID_SDK_ROOT=' + process.env['ANDROID_SDK_ROOT'] + ' (recommended setting)');
         console.log('ANDROID_HOME=' + process.env['ANDROID_HOME'] + ' (DEPRECATED)');
 
-        if (!String(values[0]).startsWith('1.8.')) {
+        if (values[0] === undefined) {
             throw new CordovaError(
-                'Requirements check failed for JDK 8 (\'1.8.*\')! Detected version: ' + values[0] + '\n' +
-                'Check your ANDROID_SDK_ROOT / JAVA_HOME / PATH environment variables.'
+                'Requirements check for Java Development Kit failed. Detected version: ' + values[0] + '\n' +
+                'Check your Java installation and ANDROID_SDK_ROOT / JAVA_HOME / PATH environment variables.'
             );
+        } else {
+            console.log('Detected JDK version: ' + values[0] + '\n');

Review comment:
       I would prefer this text to be `verbose` output, personally.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@cordova.apache.org
For additional commands, e-mail: issues-help@cordova.apache.org