You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by tillrohrmann <gi...@git.apache.org> on 2017/05/31 12:02:08 UTC
[GitHub] flink pull request #4025: [FLINK-6775] [state] Duplicate StateDescriptor's s...
GitHub user tillrohrmann opened a pull request:
https://github.com/apache/flink/pull/4025
[FLINK-6775] [state] Duplicate StateDescriptor's serializer
Duplicate the TypeSerializer before returning it from the StateDescriptor. That way
we ensure that StateDescriptors can be shared by multiple threads.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tillrohrmann/flink fixStateDescriptor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/4025.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #4025
----
commit 16cb7b12e9d8a59ad957c206f03076fca2143b71
Author: Till Rohrmann <tr...@apache.org>
Date: 2017-05-31T11:59:55Z
[FLINK-6775] [state] Duplicate StateDescriptor's serializer
Duplicate the TypeSerializer before returning it from the StateDescriptor. That way
we ensure that StateDescriptors can be shared by multiple threads.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4025: [FLINK-6775] [state] Duplicate StateDescriptor's serializ...
Posted by tzulitai <gi...@git.apache.org>.
Github user tzulitai commented on the issue:
https://github.com/apache/flink/pull/4025
LGTM, really like the change on the `testCorrectClassLoaderUsedOnSnapshot` test!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4025: [FLINK-6775] [state] Duplicate StateDescriptor's s...
Posted by aljoscha <gi...@git.apache.org>.
Github user aljoscha commented on a diff in the pull request:
https://github.com/apache/flink/pull/4025#discussion_r119340007
--- Diff: flink-core/src/test/java/org/apache/flink/api/common/state/ListStateDescriptorTest.java ---
@@ -101,4 +108,35 @@ public void testValueStateDescriptorAutoSerializer() throws Exception {
assertNotNull(copy.getElementSerializer());
assertEquals(StringSerializer.INSTANCE, copy.getElementSerializer());
}
+
+ /**
+ * FLINK-6775
+ *
+ * Tests that the returned serializer is duplicated if it is stateful. This allows to
--- End diff --
I think the wording could be a bit misleading, it's not only duplicated when it is stateful but it's always duplicated. (also holds for the other tests)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4025: [FLINK-6775] [state] Duplicate StateDescriptor's s...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on a diff in the pull request:
https://github.com/apache/flink/pull/4025#discussion_r119340919
--- Diff: flink-core/src/test/java/org/apache/flink/api/common/state/ListStateDescriptorTest.java ---
@@ -101,4 +108,35 @@ public void testValueStateDescriptorAutoSerializer() throws Exception {
assertNotNull(copy.getElementSerializer());
assertEquals(StringSerializer.INSTANCE, copy.getElementSerializer());
}
+
+ /**
+ * FLINK-6775
+ *
+ * Tests that the returned serializer is duplicated if it is stateful. This allows to
--- End diff --
Will change it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4025: [FLINK-6775] [state] Duplicate StateDescriptor's serializ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4025
Thanks for the quick review @aljoscha. Yes my filter condition was `*StateDescriptorTest`. Will add a test for the `AggregatingStateDescriptor`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink issue #4025: [FLINK-6775] [state] Duplicate StateDescriptor's serializ...
Posted by tillrohrmann <gi...@git.apache.org>.
Github user tillrohrmann commented on the issue:
https://github.com/apache/flink/pull/4025
Thanks for the review @tzulitai and @aljoscha. Failing test case is unrelated. Merging this PR.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] flink pull request #4025: [FLINK-6775] [state] Duplicate StateDescriptor's s...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/flink/pull/4025
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---