You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Hao Hao (Code Review)" <ge...@cloudera.org> on 2017/08/17 06:16:12 UTC
[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy
Hao Hao has uploaded a new change for review.
http://gerrit.cloudera.org:8080/7700
Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy
......................................................................
KUDU-1726: Avoid fsync-per-block in tablet copy
This patch incorporates BlockTransaction API with tablet
copy, to avoid fsync() on each block during copying. Blocks
are sync to disk together once the table copy is complete.
I did a manual test to copy tablet with size of ~37GB.
With this change, the operation time dropped down from ~718s
to ~523s.
Change-Id: I73822754fa3537535478bdd9a017e1cdf5b03e9a
---
A src/1943.patch
A src/deletion.patch
A src/inject_failure_test.patch
A src/inject_fault.patch
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_copy_client.h
A src/reorder.patch
A src/tablet_copy.patch
9 files changed, 3,513 insertions(+), 13 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/7700/1
--
To view, visit http://gerrit.cloudera.org:8080/7700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I73822754fa3537535478bdd9a017e1cdf5b03e9a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has uploaded a new patch set (#2).
Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy
......................................................................
KUDU-1726: Avoid fsync-per-block in tablet copy
This patch incorporates BlockTransaction API with tablet
copy, to avoid fsync() on each block during copying. Blocks
are sync to disk together once the table copy is complete.
I did a manual test to copy tablet with size of ~37GB.
With this change, the operation time dropped down from ~718s
to ~523s.
Change-Id: I73822754fa3537535478bdd9a017e1cdf5b03e9a
---
M src/kudu/tserver/tablet_copy_client-test.cc
M src/kudu/tserver/tablet_copy_client.cc
M src/kudu/tserver/tablet_copy_client.h
3 files changed, 27 insertions(+), 14 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/00/7700/2
--
To view, visit http://gerrit.cloudera.org:8080/7700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I73822754fa3537535478bdd9a017e1cdf5b03e9a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] KUDU-1726: Avoid fsync-per-block in tablet copy
Posted by "Hao Hao (Code Review)" <ge...@cloudera.org>.
Hao Hao has abandoned this change.
Change subject: KUDU-1726: Avoid fsync-per-block in tablet copy
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/7700
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: I73822754fa3537535478bdd9a017e1cdf5b03e9a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Hao Hao <ha...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins