You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@dubbo.apache.org by GitBox <gi...@apache.org> on 2021/12/24 06:24:24 UTC
[GitHub] [dubbo] codecov-commenter edited a comment on pull request #9464: fix async call issues, rpc context and response future callback race conditions
codecov-commenter edited a comment on pull request #9464:
URL: https://github.com/apache/dubbo/pull/9464#issuecomment-1000677313
# [Codecov](https://codecov.io/gh/apache/dubbo/pull/9464?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#9464](https://codecov.io/gh/apache/dubbo/pull/9464?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (205b8aa) into [3.0.5-release](https://codecov.io/gh/apache/dubbo/commit/c2b630340404f3dee3d4292692ff3234ae7ca545?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (c2b6303) will **decrease** coverage by `0.25%`.
> The diff coverage is `69.59%`.
[](https://codecov.io/gh/apache/dubbo/pull/9464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## 3.0.5-release #9464 +/- ##
===================================================
- Coverage 65.17% 64.91% -0.26%
+ Complexity 343 341 -2
===================================================
Files 1203 1204 +1
Lines 52012 52153 +141
Branches 7769 7791 +22
===================================================
- Hits 33899 33857 -42
- Misses 14489 14670 +181
- Partials 3624 3626 +2
```
| [Impacted Files](https://codecov.io/gh/apache/dubbo/pull/9464?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...apache/dubbo/common/constants/CommonConstants.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9kdWJiby9jb21tb24vY29uc3RhbnRzL0NvbW1vbkNvbnN0YW50cy5qYXZh) | `100.00% <ø> (ø)` | |
| [...in/java/org/apache/dubbo/rpc/ListenableFilter.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9MaXN0ZW5hYmxlRmlsdGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...ava/org/apache/dubbo/rpc/filter/ContextFilter.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQ29udGV4dEZpbHRlci5qYXZh) | `94.00% <ø> (ø)` | |
| [...g/apache/dubbo/rpc/proxy/AbstractProxyInvoker.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9wcm94eS9BYnN0cmFjdFByb3h5SW52b2tlci5qYXZh) | `51.28% <0.00%> (ø)` | |
| [...in/java/org/apache/dubbo/rpc/AsyncContextImpl.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9Bc3luY0NvbnRleHRJbXBsLmphdmE=) | `44.82% <20.00%> (-11.70%)` | :arrow_down: |
| [...e/dubbo/rpc/cluster/filter/FilterChainBuilder.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tY2x1c3Rlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZHViYm8vcnBjL2NsdXN0ZXIvZmlsdGVyL0ZpbHRlckNoYWluQnVpbGRlci5qYXZh) | `37.50% <60.81%> (-19.03%)` | :arrow_down: |
| [...src/main/java/org/apache/dubbo/rpc/RpcContext.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0LmphdmE=) | `41.20% <77.77%> (+4.73%)` | :arrow_up: |
| [...he/dubbo/rpc/filter/ClassLoaderCallbackFilter.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQ2xhc3NMb2FkZXJDYWxsYmFja0ZpbHRlci5qYXZh) | `80.00% <80.00%> (ø)` | |
| [...ava/org/apache/dubbo/rpc/RpcContextAttachment.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9ScGNDb250ZXh0QXR0YWNobWVudC5qYXZh) | `84.61% <85.71%> (+0.24%)` | :arrow_up: |
| [...org/apache/dubbo/rpc/filter/ClassLoaderFilter.java](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZHViYm8tcnBjL2R1YmJvLXJwYy1hcGkvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2R1YmJvL3JwYy9maWx0ZXIvQ2xhc3NMb2FkZXJGaWx0ZXIuamF2YQ==) | `87.50% <86.66%> (-12.50%)` | :arrow_down: |
| ... and [37 more](https://codecov.io/gh/apache/dubbo/pull/9464/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/dubbo/pull/9464?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/dubbo/pull/9464?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [c2b6303...205b8aa](https://codecov.io/gh/apache/dubbo/pull/9464?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org