You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/06/03 05:59:46 UTC

[GitHub] [pulsar] mattisonchao opened a new pull request, #15917: [improve][broker] Make `NamespaceBase#deleteNamespace` to pure async

mattisonchao opened a new pull request, #15917:
URL: https://github.com/apache/pulsar/pull/15917

   ### Motivation
   
   See PIP #14365  and change tracker #15043. 
   
   ### Modifications
   
   - Make `NamespaceBase` `deleteNamespace` to pure async.
   - Clean up the duplicated code.
   - Improve the delete topic logic, remove the normal topic first and then remove the system topic.
   
   ### Verifying this change
   
   - [x] Make sure that the change passes the CI checks.
   
   `AdminTest#clusters` already cover this change.
   
   ### Documentation
   
   - [x] `no-need-doc` 
   (Please explain why)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15917: [improve][broker] Make `NamespaceBase#deleteNamespace` to pure async

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15917:
URL: https://github.com/apache/pulsar/pull/15917#issuecomment-1145613530

   @mattisonchao:Thanks for your contribution. For this PR, do we need to update docs?
   (The [PR template contains info about doc](https://github.com/apache/pulsar/blob/master/.github/PULL_REQUEST_TEMPLATE.md#documentation), which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] mattisonchao closed pull request #15917: [improve][broker] Make `NamespaceBase#deleteNamespace` to pure async

Posted by GitBox <gi...@apache.org>.
mattisonchao closed pull request #15917: [improve][broker] Make `NamespaceBase#deleteNamespace` to pure async
URL: https://github.com/apache/pulsar/pull/15917


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] github-actions[bot] commented on pull request #15917: [improve][broker] Make `NamespaceBase#deleteNamespace` to pure async

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15917:
URL: https://github.com/apache/pulsar/pull/15917#issuecomment-1176964488

   The pr had no activity for 30 days, mark with Stale label.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org