You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Prabhjyot Singh <pr...@gmail.com> on 2017/07/27 04:52:11 UTC

Review Request 61169: Remove environment variables from zeppelin-env.sh

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61169/
-----------------------------------------------------------

Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21585
    https://issues.apache.org/jira/browse/AMBARI-21585


Repository: ambari


Description
-------

This is to remove three of the environment variables from zeppelin-env.sh;
 - `ZEPPELIN_JAVA_OPTS` this initialises spark.executor.memory, spark.executor.instances and spark.yarn.queue which should ideally be configured in Zeppelin's interpreter setting to avoid confusion.
 - `SPARK_YARN_USER_ENV` is no longer used.
 - `PYTHONPATH` if required should be configured from Zeppelin's interpreter setting.


Diffs
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml 80ac2bbd45 


Diff: https://reviews.apache.org/r/61169/diff/1/


Testing
-------

Manually on CentOS 7


Thanks,

Prabhjyot Singh


Re: Review Request 61169: Remove environment variables from zeppelin-env.sh

Posted by Gaurav Nagar <gn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61169/#review181547
-----------------------------------------------------------


Ship it!




Ship It!

- Gaurav Nagar


On July 27, 2017, 5:09 a.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61169/
> -----------------------------------------------------------
> 
> (Updated July 27, 2017, 5:09 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21585
>     https://issues.apache.org/jira/browse/AMBARI-21585
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is to remove three of the environment variables from zeppelin-env.sh;
>  - `ZEPPELIN_JAVA_OPTS` this initialises spark.executor.memory, spark.executor.instances and spark.yarn.queue which should ideally be configured in Zeppelin's interpreter setting to avoid confusion.
>  - `SPARK_YARN_USER_ENV` is no longer used.
>  - `PYTHONPATH` if required should be configured from Zeppelin's interpreter setting.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml 80ac2bbd45 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml 7bd597f6a6 
> 
> 
> Diff: https://reviews.apache.org/r/61169/diff/2/
> 
> 
> Testing
> -------
> 
> Manually on CentOS 7
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 61169: Remove environment variables from zeppelin-env.sh

Posted by venkat sairam <ve...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61169/#review181545
-----------------------------------------------------------


Ship it!




Ship It!

- venkat sairam


On July 27, 2017, 5:09 a.m., Prabhjyot Singh wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61169/
> -----------------------------------------------------------
> 
> (Updated July 27, 2017, 5:09 a.m.)
> 
> 
> Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and venkat sairam.
> 
> 
> Bugs: AMBARI-21585
>     https://issues.apache.org/jira/browse/AMBARI-21585
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> This is to remove three of the environment variables from zeppelin-env.sh;
>  - `ZEPPELIN_JAVA_OPTS` this initialises spark.executor.memory, spark.executor.instances and spark.yarn.queue which should ideally be configured in Zeppelin's interpreter setting to avoid confusion.
>  - `SPARK_YARN_USER_ENV` is no longer used.
>  - `PYTHONPATH` if required should be configured from Zeppelin's interpreter setting.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml 80ac2bbd45 
>   ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml 7bd597f6a6 
> 
> 
> Diff: https://reviews.apache.org/r/61169/diff/2/
> 
> 
> Testing
> -------
> 
> Manually on CentOS 7
> 
> 
> Thanks,
> 
> Prabhjyot Singh
> 
>


Re: Review Request 61169: Remove environment variables from zeppelin-env.sh

Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61169/
-----------------------------------------------------------

(Updated Aug. 22, 2017, 4:45 p.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21585
    https://issues.apache.org/jira/browse/AMBARI-21585


Repository: ambari


Description
-------

This is to remove three of the environment variables from zeppelin-env.sh;
 - `ZEPPELIN_JAVA_OPTS` this initialises spark.executor.memory, spark.executor.instances and spark.yarn.queue which should ideally be configured in Zeppelin's interpreter setting to avoid confusion.
 - `SPARK_YARN_USER_ENV` is no longer used.
 - `PYTHONPATH` if required should be configured from Zeppelin's interpreter setting.


Diffs
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml 80ac2bbd45 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml 7bd597f6a6 


Diff: https://reviews.apache.org/r/61169/diff/2/


Testing
-------

Manually on CentOS 7


Thanks,

Prabhjyot Singh


Re: Review Request 61169: Remove environment variables from zeppelin-env.sh

Posted by Prabhjyot Singh <pr...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61169/
-----------------------------------------------------------

(Updated July 27, 2017, 10:39 a.m.)


Review request for Ambari, Attila Doroszlai, Alejandro Fernandez, DIPAYAN BHOWMICK, Jayush Luniya, Rohit Choudhary, Renjith Kamath, Sumit Mohanty, and venkat sairam.


Bugs: AMBARI-21585
    https://issues.apache.org/jira/browse/AMBARI-21585


Repository: ambari


Description
-------

This is to remove three of the environment variables from zeppelin-env.sh;
 - `ZEPPELIN_JAVA_OPTS` this initialises spark.executor.memory, spark.executor.instances and spark.yarn.queue which should ideally be configured in Zeppelin's interpreter setting to avoid confusion.
 - `SPARK_YARN_USER_ENV` is no longer used.
 - `PYTHONPATH` if required should be configured from Zeppelin's interpreter setting.


Diffs (updated)
-----

  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.2.5/configuration/zeppelin-env.xml 80ac2bbd45 
  ambari-server/src/main/resources/common-services/ZEPPELIN/0.6.0.3.0/configuration/zeppelin-env.xml 7bd597f6a6 


Diff: https://reviews.apache.org/r/61169/diff/2/

Changes: https://reviews.apache.org/r/61169/diff/1-2/


Testing
-------

Manually on CentOS 7


Thanks,

Prabhjyot Singh