You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by epahomov <gi...@git.apache.org> on 2017/01/08 23:04:13 UTC
[GitHub] zeppelin pull request #1873: [ZEPPELIN-1922] Exclude jackson-core and jackso...
GitHub user epahomov opened a pull request:
https://github.com/apache/zeppelin/pull/1873
[ZEPPELIN-1922] Exclude jackson-core and jackson-databind from aws dep
### What is this PR for?
Master version of https://github.com/apache/zeppelin/pull/1872
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-1922
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/epahomov/incubator-zeppelin ZEPPELIN-1922-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/1873.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1873
----
commit 66e61c0a3d0049bf0396676c81749c6aefbf59dc
Author: epahomov <eg...@anchorfree.com>
Date: 2017-01-08T23:01:46Z
[ZEPPELIN-1922] Exclude jackson-core and jackson-databind from aws dep
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1873: [ZEPPELIN-1922] Exclude jackson-core and jackson-datab...
Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:
https://github.com/apache/zeppelin/pull/1873
@epahomov Thanks for the contribution.
I'm trying to understand what cause this problem, because `zeppelin-zengine` shouldn't be a dependency of any interpreter and `/lib` directory supposed to not be included in the classpath of interpreter process.
So excluding some library from `zeppelin-zengine` or removing jar from `lib/` directory shouldn't affect anything about classloading in interpreter.
@epahomov, could you elaborate how interpreter classpath includes dependencies of `zeppelin-zengine` module?
cc @jongyoul
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1873: [ZEPPELIN-1922] Exclude jackson-core and jackson-datab...
Posted by felixcheung <gi...@git.apache.org>.
Github user felixcheung commented on the issue:
https://github.com/apache/zeppelin/pull/1873
I guess the question is by excluding this would it break something down the line?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin issue #1873: [ZEPPELIN-1922] Exclude jackson-core and jackson-datab...
Posted by epahomov <gi...@git.apache.org>.
Github user epahomov commented on the issue:
https://github.com/apache/zeppelin/pull/1873
@Leemoonsoo , honestly speaking, I don't know. But I've tested this fix in very isolated env(docker) and it's fixes it. I'm not saying that it's strong argument to fix issue this way, but may be it can give you some clue
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] zeppelin pull request #1873: [ZEPPELIN-1922] Exclude jackson-core and jackso...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/zeppelin/pull/1873
---