You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@submarine.apache.org by GitBox <gi...@apache.org> on 2021/04/22 06:30:12 UTC

[GitHub] [submarine] kevin85421 opened a new pull request #562: SUBMARINE-800. Create an ingress for a single user

kevin85421 opened a new pull request #562:
URL: https://github.com/apache/submarine/pull/562


   ### What is this PR for?
   Create an ingress for a single user via the submarine operator.
   Reference: https://github.com/apache/submarine/blob/master/helm-charts/submarine/templates/submarine-ingress.yaml
   
   This issue is a child issue of [SUBMARINE-797](https://issues.apache.org/jira/browse/SUBMARINE-797).
   
   ### What type of PR is it?
   [Feature]
   
   ### Todos
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/SUBMARINE-800
   
   ### How should this be tested?
   ```
   # helm
   helm install submarine ./helm-charts/submarine
   kubectl get ingress
   kubectl describe ingress submarine-server-ingress
   
   # submarine-operator
   go build -o submarine-operator
   ./submarine-operator
   kubectl get ingress
   kubectl describe ingress submarine-server-ingress
   ```
   
   ### Screenshots (if appropriate)
   * submarine-server-ingress (helm)
   <img width="817" alt="截圖 2021-04-22 下午2 25 25" src="https://user-images.githubusercontent.com/20109646/115666391-1d1fef80-a377-11eb-9d14-7282636d2efe.png">
   
   * submarine-server-ingress (submarine-operator)
   <img width="935" alt="截圖 2021-04-22 下午2 11 18" src="https://user-images.githubusercontent.com/20109646/115666380-198c6880-a377-11eb-957a-11bf24c07c7c.png">
   
   
   
   ### Questions:
   * Do the license files need updating? No
   * Are there breaking changes for older versions? No
   * Does this need new documentation? No
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [submarine] kevin85421 merged pull request #562: SUBMARINE-800. Create an ingress for a single user

Posted by GitBox <gi...@apache.org>.
kevin85421 merged pull request #562:
URL: https://github.com/apache/submarine/pull/562


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org