[GitHub] [hudi] nsivabalan commented on a diff in pull request #6763: [HUDI-4906] Fix the local tests for hudi-flink

[GitBox <gi...@apache.org>]

nsivabalan commented on code in PR #6763:
URL: https://github.com/apache/hudi/pull/6763#discussion_r978930635


##########
hudi-flink-datasource/hudi-flink/pom.xml:
##########
@@ -230,7 +230,8 @@
         <dependency>
             <groupId>org.apache.avro</groupId>
             <artifactId>avro</artifactId>
-            <version>${avro.version}</version>
+            <!-- Override the version to be same with Flink avro -->
+            <version>1.10.0</version>

Review Comment:
   not required in this patch. but can we introduce a variable (flink.avro.version) and use that. 



##########
packaging/hudi-flink-bundle/pom.xml:
##########
@@ -501,7 +501,8 @@
     <dependency>
       <groupId>org.apache.avro</groupId>
       <artifactId>avro</artifactId>
-      <version>${avro.version}</version>
+      <!-- Override the version to be same with Flink avro -->
+      <version>1.10.0</version>

Review Comment:
   same here.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org