[GitHub] [tvm] areusch commented on a change in pull request #9003: [microTVM][AutoTVM] Fix autotvm bug and tests

[GitBox <gi...@apache.org>]

areusch commented on a change in pull request #9003:
URL: https://github.com/apache/tvm/pull/9003#discussion_r708482719



##########
File path: src/runtime/rpc/rpc_endpoint.cc
##########
@@ -691,11 +691,13 @@ void RPCEndpoint::Init() {
  *     the key to modify their behavior.
  */
 std::shared_ptr<RPCEndpoint> RPCEndpoint::Create(std::unique_ptr<RPCChannel> channel,
-                                                 std::string name, std::string remote_key) {
+                                                 std::string name, std::string remote_key,
+                                                 TypedPackedFunc<void()> fshutdown) {

Review comment:
       @tqchen this is needed when a Python-side session constructor may keep a reference to the underlying session. Does it make sense to you?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org