You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2021/09/26 13:22:12 UTC

[GitHub] [tvm] Mousius commented on issue #9057: [VOTE] Adopt round-robin assignment of reviewers for GitHub pull request reviewer assignment.

Mousius commented on issue #9057:
URL: https://github.com/apache/tvm/issues/9057#issuecomment-927306011


   -1
   
   I don't believe this is will solve the problem of "assigning far too many pull requests to far too many people and not providing fair scheduling across all reviewers" and may introduce other issues. I believe this will result in is code owners missing pull requests which are relevant to them and recreating the "review-by-request" we had previously, when a less active code owner isn't available then help will be requested from the more active code owners in the community.
   
   This is based on analysis on the last 1000 merge commits in `main`, using the associated responsibility of reviewing and merging code into the codebase. The analysis shows over those 1000 commits there were a set of active committers doing the majority of the merging, whereas others had other priorities, which I believe is fair in an open source project. Those active committers didn't change significantly after changes #8500 or #8512.
   
   I'm therefore concerned that this change reduces the visibility of pull requests to active committers, decreases the likelihood of a given pull request being reviewed and not materially effecting the workload for active committers.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org