You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/09/15 22:12:21 UTC

[jira] [Work logged] (TS-4868) Latest master requires config value in file

     [ https://issues.apache.org/jira/browse/TS-4868?focusedWorklogId=29219&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-29219 ]

ASF GitHub Bot logged work on TS-4868:
--------------------------------------

                Author: ASF GitHub Bot
            Created on: 15/Sep/16 22:12
            Start Date: 15/Sep/16 22:12
    Worklog Time Spent: 10m 
      Work Description: Github user bryancall commented on a diff in the pull request:

    https://github.com/apache/trafficserver/pull/1022#discussion_r79073490
  
    --- Diff: mgmt/RecordsConfig.cc ---
    @@ -834,6 +860,61 @@ static const RecordElement RecordsConfig[] =
     
       //##############################################################################
       //#
    +  //# Cluster Subsystem
    +  //#
    +  //##############################################################################
    +  {RECT_CONFIG, "proxy.config.cluster.threads", RECD_INT, "1", RECU_RESTART_TS, RR_NULL, RECC_INT, "[0-512]", RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.cluster_port", RECD_INT, "8086", RECU_RESTART_TS, RR_REQUIRED, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.cluster_configuration", RECD_STRING, "cluster.config", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.ethernet_interface", RECD_STRING, TS_BUILD_DEFAULT_LOOPBACK_IFACE, RECU_RESTART_TS, RR_REQUIRED, RECC_STR, "^[^[:space:]]*$", RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.enable_monitor", RECD_INT, "0", RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.monitor_interval_secs", RECD_INT, "1", RECU_DYNAMIC, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.send_buffer_size", RECD_INT, "10485760", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.receive_buffer_size", RECD_INT, "10485760", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.sock_option_flag", RECD_INT, "0x0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.sock_packet_mark", RECD_INT, "0x0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.sock_packet_tos", RECD_INT, "0x0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.rpc_cache_cluster", RECD_INT, "0", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +
    +  //##################################################################
    +  //# Cluster interconnect load monitoring configuration options.
    +  //# Internal use only
    +  //##################################################################
    +  //# load monitor_enabled: -1 = compute only, 0 = disable, 1 = compute and act
    +  {RECT_CONFIG, "proxy.config.cluster.load_monitor_enabled", RECD_INT, "1", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.ping_send_interval_msecs", RECD_INT, "100", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.ping_response_buckets", RECD_INT, "100", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.msecs_per_ping_response_bucket", RECD_INT, "50", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.ping_latency_threshold_msecs", RECD_INT, "500", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.load_compute_interval_msecs", RECD_INT, "5000", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.periodic_timer_interval_msecs", RECD_INT, "100", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.ping_history_buf_length", RECD_INT, "120", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.cluster_load_clear_duration", RECD_INT, "24", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    +  {RECT_CONFIG, "proxy.config.cluster.cluster_load_exceed_duration", RECD_INT, "4", RECU_NULL, RR_NULL, RECC_NULL, NULL, RECA_NULL}
    +  ,
    --- End diff --
    
    Why do the configs need to be added back in?


Issue Time Tracking
-------------------

    Worklog Id:     (was: 29219)
    Time Spent: 1h 50m  (was: 1h 40m)

> Latest master requires config value in file
> -------------------------------------------
>
>                 Key: TS-4868
>                 URL: https://issues.apache.org/jira/browse/TS-4868
>             Project: Traffic Server
>          Issue Type: Bug
>            Reporter: Jason Kenny
>            Assignee: Phil Sorber
>            Priority: Blocker
>             Fix For: 7.1.0
>
>          Time Spent: 1h 50m
>  Remaining Estimate: 0h
>
> <1473896704.0000> [FATAL]: could not find integer variable proxy.local.cluster.type in records.config
> This is a regression. Our configuration system allows for defaults to be defined. records.config needs to stay optional.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)