You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/09/09 21:31:02 UTC

[GitHub] [incubator-mxnet] Zha0q1 opened a new pull request #19106: Elemwise binary op backward fix

Zha0q1 opened a new pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106


   This pr fixes backward of elementwise binary ops against large tensor.
   
   Tests are also added
   
   sample run:
   ```
   ubuntu@ip-172-31-38-169:~/incubator-mxnet$ pytest tests/nightly/test_np_large_array.py::test_subtract
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   /home/ubuntu/anaconda3/lib/python3.7/importlib/_bootstrap.py:219: RuntimeWarning: numpy.ufunc size changed, may indicate binary incompatibility. Expected 192 from C header, got 216 from PyObject
     return f(*args, **kwds)
   ===================================== test session starts ======================================
   platform linux -- Python 3.7.7, pytest-5.4.1, py-1.8.1, pluggy-0.13.1
   rootdir: /home/ubuntu/incubator-mxnet, inifile: pytest.ini
   plugins: remotedata-0.3.2, openfiles-0.4.0, astropy-header-0.1.2, hypothesis-5.8.3, arraydiff-0.3, doctestplus-0.5.0
   collected 1 item                                                                               
   
   tests/nightly/test_np_large_array.py .                                                   [100%]
   
   ======================================= warnings summary =======================================
   tests/nightly/test_np_large_array.py:89
     /home/ubuntu/incubator-mxnet/tests/nightly/test_np_large_array.py:89: DeprecationWarning: invalid escape sequence \ 
       '''
   
   tests/nightly/test_np_large_array.py:674
     /home/ubuntu/incubator-mxnet/tests/nightly/test_np_large_array.py:674: DeprecationWarning: invalid escape sequence \ 
       '''
   
   -- Docs: https://docs.pytest.org/en/latest/warnings.html
   ================================ 1 passed, 2 warnings in 14.77s ==============================
   ```


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] mxnet-bot commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-689832797


   Hey @Zha0q1 , Thanks for submitting the PR 
   All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands: 
   - To trigger all jobs: @mxnet-bot run ci [all] 
   - To trigger specific jobs: @mxnet-bot run ci [job1, job2] 
   *** 
   **CI supported jobs**: [website, unix-gpu, clang, miscellaneous, edge, unix-cpu, centos-gpu, sanity, windows-gpu, centos-cpu, windows-cpu]
   *** 
   _Note_: 
    Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin. 
   All CI tests must pass before the PR can be merged. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691263038


   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691267086


   @mxnet-label-bot add [pr-work-in-progress]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691275110


   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha merged pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
szha merged pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691247097


   @mxnet-label-bot add [pr-work-in-progress]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691268572


   @ChaiBapchya what's going on with the label bot?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691247097






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691273056


   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691260886


   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691268572


   @ChaiBapchya what's going on with the label bot?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691247362


   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 removed a comment on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 removed a comment on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691247097






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 removed a comment on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 removed a comment on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691273056






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691264005


   
   
   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 removed a comment on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 removed a comment on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691267086






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691252126


   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691261509


   @mxnet-label-bot add [pr-work-in-progress]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 removed a comment on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 removed a comment on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691275110






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691268572


   @ChaiBapchya what's going on with the label bot?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 removed a comment on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 removed a comment on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691261255






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 removed a comment on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 removed a comment on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691273056


   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691263796


   @mxnet-label-bot add [pr-work-in-progress]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691269608


   > @ChaiBapchya what's going on with the label bot?
   
   I was testing the label bot to fix an api security issue. Sorry if this created an overflow of notifications 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 removed a comment on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 removed a comment on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691273056






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691248495


   @mxnet-label-bot add [pr-work-in-progress]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691247149


   @mxnet-label-bot add [pr-work-in-progress]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691261255


   @mxnet-label-bot update [pr-awaiting-review]


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] Zha0q1 commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
Zha0q1 commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691247097






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [incubator-mxnet] szha commented on pull request #19106: Elemwise binary op backward fix

Posted by GitBox <gi...@apache.org>.
szha commented on pull request #19106:
URL: https://github.com/apache/incubator-mxnet/pull/19106#issuecomment-691268572






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org