You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@celix.apache.org by GitBox <gi...@apache.org> on 2022/02/24 09:10:44 UTC

[GitHub] [celix] PengZheng commented on a change in pull request #399: Service tracker improvements

PengZheng commented on a change in pull request #399:
URL: https://github.com/apache/celix/pull/399#discussion_r813680366



##########
File path: libs/framework/src/bundle_context.c
##########
@@ -1208,9 +1208,9 @@ bool celix_bundleContext_useServiceWithOptions(
     long eventId = celix_framework_fireGenericEvent(ctx->framework, -1, celix_bundle_getId(ctx->bundle), "create service tracker for celix_bundleContext_useServiceWithOptions", &data, celix_bundleContext_useServiceWithOptions_1_CreateServiceTracker, NULL, NULL);
     celix_framework_waitForGenericEvent(ctx->framework, eventId);
 
-    celix_framework_waitForEmptyEventQueue(ctx->framework); //ensure that a useService wait if a listener hooks concept, which triggers an async service registration

Review comment:
       This is not necessary for the indirect call path, since the following generic event sync with these async service registration.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@celix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org