You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by jbertram <gi...@git.apache.org> on 2016/06/30 19:30:28 UTC

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

GitHub user jbertram opened a pull request:

    https://github.com/apache/activemq-artemis/pull/613

    ARTEMIS-602 Fix REST examples

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbertram/activemq-artemis restExamples

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/activemq-artemis/pull/613.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #613
    
----
commit 2bd7edacb362ecfe574d0a04baea6f6da056b7f4
Author: jbertram <jb...@apache.org>
Date:   2016-06-30T18:04:04Z

    ARTEMIS-602 Fix REST examples

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #613: ARTEMIS-602 Fix REST examples

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/613
  
    The PR test build fails with:
    
    [ERROR] Failed to execute goal on project artemis-web: Could not resolve dependencies for project org.apache.activemq:artemis-web:jar:1.4.0-SNAPSHOT: Could not find artifact org.eclipse.jetty.aggregate:jetty-all:jar:9.3.10.v20160621 in central (http://repo.maven.apache.org/maven2) -> [Help 1]
    
    However, the dependency is there at http://repo.maven.apache.org/maven2/org/eclipse/jetty/aggregate/jetty-all/9.3.10.v20160621/ so I don't understand what the problem is.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/613#discussion_r69366595
  
    --- Diff: examples/features/standard/rest/javascript-chat/README.txt ---
    @@ -1,5 +1,5 @@
     System Requirements:
    -You will need JDK 1.6, Maven, and a browser to run this example.  This example has been tested with Maven 2.2.1.  It may or may not work
    --- End diff --
    
    1.7?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/613#discussion_r69583184
  
    --- Diff: examples/features/standard/rest/dup-send/README.txt ---
    @@ -1,5 +1,5 @@
     System Requirements:
    -You will need JDK 1.6 and Maven to run this example.  This example has been tested with Maven 2.2.1.  It may or may not work 
    +You will need JDK 1.8 and Maven to run this example.  This example has been tested with Maven 3.3.3.  It may or may not work
    --- End diff --
    
    We can probably leave 1.8 on the docs, and still let the build to work with 1.7.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis issue #613: ARTEMIS-602 Fix REST examples

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on the issue:

    https://github.com/apache/activemq-artemis/pull/613
  
    I sorted the dependency issue out, and I also ran the PR check on my local machine since the Apache CI seems to be flaky right now. It passed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

Posted by jbertram <gi...@git.apache.org>.
Github user jbertram commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/613#discussion_r69371083
  
    --- Diff: examples/features/standard/rest/dup-send/README.txt ---
    @@ -1,5 +1,5 @@
     System Requirements:
    -You will need JDK 1.6 and Maven to run this example.  This example has been tested with Maven 2.2.1.  It may or may not work 
    +You will need JDK 1.8 and Maven to run this example.  This example has been tested with Maven 3.3.3.  It may or may not work
    --- End diff --
    
    Are we stuck on 1.7?  It's been EOL for over a year now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/activemq-artemis/pull/613


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] activemq-artemis pull request #613: ARTEMIS-602 Fix REST examples

Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on a diff in the pull request:

    https://github.com/apache/activemq-artemis/pull/613#discussion_r69366570
  
    --- Diff: examples/features/standard/rest/dup-send/README.txt ---
    @@ -1,5 +1,5 @@
     System Requirements:
    -You will need JDK 1.6 and Maven to run this example.  This example has been tested with Maven 2.2.1.  It may or may not work 
    +You will need JDK 1.8 and Maven to run this example.  This example has been tested with Maven 3.3.3.  It may or may not work
    --- End diff --
    
    1.7 ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---