You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2021/06/15 04:24:33 UTC

[GitHub] [helix] huizhilu commented on pull request #1796: Add message util to create messages

huizhilu commented on pull request #1796:
URL: https://github.com/apache/helix/pull/1796#issuecomment-861158356


   This PR is ready to be merged, approved by @alirezazamani 
   
   Message creation methods are private in message generation phase. Management mode stage will also need message generation methods to create ST cancellation and participant status change messages.
   Message util will help with the purposes.
   
   This commit moves the common message creation logic to a message util so multiple stages can reuse the code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org