You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by "sandynz (via GitHub)" <gi...@apache.org> on 2023/02/19 10:47:28 UTC
[GitHub] [shardingsphere] sandynz opened a new pull request, #24242: Add faked MariaDBMigrationE2EIT
sandynz opened a new pull request, #24242:
URL: https://github.com/apache/shardingsphere/pull/24242
Changes proposed in this pull request:
- Add faked MariaDBMigrationE2EIT
- Improve IndexesMigrationE2EIT
- Improve part of pipeline job api unit test
---
Before committing this PR, I'm sure that I have checked the following options:
- [ ] My code follows the [code of conduct](https://shardingsphere.apache.org/community/en/involved/conduct/code/) of this project.
- [ ] I have self-reviewed the commit code.
- [ ] I have (or in comment I request) added corresponding labels for the pull request.
- [ ] I have passed maven check locally : `./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e`.
- [ ] I have made corresponding changes to the documentation.
- [ ] I have added corresponding unit tests for my changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] codecov-commenter commented on pull request #24242: Add faked MariaDBMigrationE2EIT
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #24242:
URL: https://github.com/apache/shardingsphere/pull/24242#issuecomment-1435965968
# [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#24242](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a002d9) into [master](https://codecov.io/gh/apache/shardingsphere/commit/680a4eaec4ca727e68e5a9214c25f637dc3fa8ba?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (680a4ea) will **increase** coverage by `0.03%`.
> The diff coverage is `50.00%`.
> :exclamation: Current head 7a002d9 differs from pull request most recent head dee4e79. Consider uploading reports for the commit dee4e79 to get more accurate results
```diff
@@ Coverage Diff @@
## master #24242 +/- ##
============================================
+ Coverage 49.92% 49.96% +0.03%
Complexity 1573 1573
============================================
Files 3256 3256
Lines 53405 53405
Branches 9840 9840
============================================
+ Hits 26661 26682 +21
+ Misses 24382 24358 -24
- Partials 2362 2365 +3
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...proxy/backend/communication/BackendConnection.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vQmFja2VuZENvbm5lY3Rpb24uamF2YQ==) | `83.55% <ø> (ø)` | |
| [...end/communication/DatabaseCommunicationEngine.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vRGF0YWJhc2VDb21tdW5pY2F0aW9uRW5naW5lLmphdmE=) | `56.25% <ø> (ø)` | |
| [...munication/DatabaseCommunicationEngineFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vRGF0YWJhc2VDb21tdW5pY2F0aW9uRW5naW5lRmFjdG9yeS5qYXZh) | `85.71% <ø> (ø)` | |
| [.../proxy/backend/communication/ProxySQLExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vUHJveHlTUUxFeGVjdXRvci5qYXZh) | `28.94% <ø> (ø)` | |
| [...nd/communication/jdbc/connection/ResourceLock.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9jb25uZWN0aW9uL1Jlc291cmNlTG9jay5qYXZh) | `100.00% <ø> (ø)` | |
| [...ication/jdbc/datasource/JDBCBackendDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9kYXRhc291cmNlL0pEQkNCYWNrZW5kRGF0YVNvdXJjZS5qYXZh) | `61.76% <ø> (ø)` | |
| [...communication/jdbc/executor/ProxyJDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9leGVjdXRvci9Qcm94eUpEQkNFeGVjdXRvci5qYXZh) | `0.00% <ø> (ø)` | |
| [...c/executor/callback/ProxyJDBCExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9leGVjdXRvci9jYWxsYmFjay9Qcm94eUpEQkNFeGVjdXRvckNhbGxiYWNrLmphdmE=) | `15.62% <ø> (ø)` | |
| [...tor/callback/ProxyJDBCExecutorCallbackFactory.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9leGVjdXRvci9jYWxsYmFjay9Qcm94eUpEQkNFeGVjdXRvckNhbGxiYWNrRmFjdG9yeS5qYXZh) | `20.00% <ø> (ø)` | |
| [...k/impl/ProxyPreparedStatementExecutorCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cHJveHkvYmFja2VuZC9jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9wcm94eS9iYWNrZW5kL2NvbW11bmljYXRpb24vamRiYy9leGVjdXRvci9jYWxsYmFjay9pbXBsL1Byb3h5UHJlcGFyZWRTdGF0ZW1lbnRFeGVjdXRvckNhbGxiYWNrLmphdmE=) | `66.66% <ø> (ø)` | |
| ... and [166 more](https://codecov.io/gh/apache/shardingsphere/pull/24242?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] sandynz commented on pull request #24242: Add faked MariaDBMigrationE2EIT
Posted by "sandynz (via GitHub)" <gi...@apache.org>.
sandynz commented on PR #24242:
URL: https://github.com/apache/shardingsphere/pull/24242#issuecomment-1435979048
TODO:
After MariaDB java client could connect to proxy, real MariaDB migration E2E will be enabled.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] tristaZero merged pull request #24242: Add faked MariaDBMigrationE2EIT
Posted by "tristaZero (via GitHub)" <gi...@apache.org>.
tristaZero merged PR #24242:
URL: https://github.com/apache/shardingsphere/pull/24242
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org