[jira] Updated: (SOLR-1644) Provide a clean way to keep flags and helper objects in ResponseBuilder

["Noble Paul (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-1644?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Noble Paul updated SOLR-1644:
-----------------------------

    Attachment: SOLR-1644.patch

A new Map is kept is ResponseBuilder. It is also possible to use SolrQueryRequest.getContext(). Let us make that call.

Every component keeps a private Object as the key and stores values by that key in rb.store . No other component can access that value because the key is a private Object  (So no conflict).  The patch illustrates  how FacetComponent has eliminated the variables from ResponseBuilder. If it is fine , we can remove the rest of it too such as doStats,needDocList,needDocSet etc

> Provide a clean way to keep flags and helper objects in ResponseBuilder
> -----------------------------------------------------------------------
>
>                 Key: SOLR-1644
>                 URL: https://issues.apache.org/jira/browse/SOLR-1644
>             Project: Solr
>          Issue Type: Improvement
>          Components: search
>            Reporter: Shalin Shekhar Mangar
>            Assignee: Shalin Shekhar Mangar
>             Fix For: 1.5
>
>         Attachments: SOLR-1644.patch
>
>
> Many components such as StatsComponent, FacetComponent etc keep flags and helper objects in ResponseBuilder. Having to modify the ResponseBuilder for such things is a very kludgy solution.
> Let us provide a clean way for components to keep arbitrary objects for the duration of a (distributed) search request.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.