You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Joseph Wu <jo...@mesosphere.io> on 2016/01/08 21:08:34 UTC
Review Request 42084: Fixed header order.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42084/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
Repository: mesos
Description
-------
Rearranged headers to pull out the `#include <stout/os/...>` into a separate group.
Pulled libprocess headers in front of stout headers in a few files.
Diffs
-----
src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54
src/log/tool/benchmark.cpp 9cb60bd66f53e0d191d96a429bfca89d91412339
src/slave/containerizer/mesos/provisioner/appc/spec.cpp 324cdfec3766da4a8e324378a6e413477fa2b5d9
src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b74c760e90b12f5bf45b6e626e2b661f841e5a8d
src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec
src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8
Diff: https://reviews.apache.org/r/42084/diff/
Testing
-------
make check
Thanks,
Joseph Wu
Re: Review Request 42084: Fixed header order.
Posted by Klaus Ma <kl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42084/#review113584
-----------------------------------------------------------
Ship it!
Ship It!
- Klaus Ma
On Jan. 9, 2016, 4:08 a.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42084/
> -----------------------------------------------------------
>
> (Updated Jan. 9, 2016, 4:08 a.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rearranged headers to pull out the `#include <stout/os/...>` into a separate group.
> Pulled libprocess headers in front of stout headers in a few files.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54
> src/log/tool/benchmark.cpp 9cb60bd66f53e0d191d96a429bfca89d91412339
> src/slave/containerizer/mesos/provisioner/appc/spec.cpp 324cdfec3766da4a8e324378a6e413477fa2b5d9
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b74c760e90b12f5bf45b6e626e2b661f841e5a8d
> src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec
> src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8
>
> Diff: https://reviews.apache.org/r/42084/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>
Re: Review Request 42084: Fixed header order.
Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42084/#review113578
-----------------------------------------------------------
Patch looks great!
Reviews applied: [42082, 42083, 42084]
Passed command: export OS=ubuntu:14.04;export CONFIGURATION="--verbose";export COMPILER=gcc; ./support/docker_build.sh
- Mesos ReviewBot
On Jan. 8, 2016, 8:08 p.m., Joseph Wu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42084/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2016, 8:08 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Artem Harutyunyan.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Rearranged headers to pull out the `#include <stout/os/...>` into a separate group.
> Pulled libprocess headers in front of stout headers in a few files.
>
>
> Diffs
> -----
>
> src/docker/docker.cpp e93280735f1c5f66c765fcbabfd3e50b46c024e8
> src/linux/ns.hpp 244a811b299c29b1dcd6652bd26e861e04df3f54
> src/log/tool/benchmark.cpp 9cb60bd66f53e0d191d96a429bfca89d91412339
> src/slave/containerizer/mesos/provisioner/appc/spec.cpp 324cdfec3766da4a8e324378a6e413477fa2b5d9
> src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp b74c760e90b12f5bf45b6e626e2b661f841e5a8d
> src/slave/qos_controllers/load.cpp 52520d6220784423c09001b8bd59e090ebf787ec
> src/tests/containerizer/provisioner_backend_tests.cpp 25b28ef8fa5aae81e8dd0c9e33df4160dd912ce8
>
> Diff: https://reviews.apache.org/r/42084/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Joseph Wu
>
>